Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 2.2 schema to support atprotocol protocol and record usage #100

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update 2.2 schema to support atprotocol protocol and record usage #100

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions schemas/2.2/schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,7 @@
"items": {
"enum": [
"activitypub",
"atprotocol",
"buddycloud",
"dfrn",
"diaspora",
Expand Down Expand Up @@ -200,6 +201,19 @@
"description": "The amount of comments that were made by users that are registered on this server.",
"type": "integer",
"minimum": 0
},
"records": {
"description": "statistics about the records created on this server by collection.",
"type": "object",
"minProperties": 0,
"additionalProperties": { "type": "integer", "minimum": 0 },
"properties": {
"app.bsky.feed.post": {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm! This sounds the same as localPosts, right? Seems like it'd maybe be better to keep all of these stats protocol-independent and unified...? I know that means we might not get as much nuance about each specific protocol, but the goal here probably isn't to be comprehensive or exhaustive anyway.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this denotes a 2.3 change, but I think limiting metrics to just post types should be deprecated. It's time to push for an expanded and more generic record-type container.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure! More metrics sounds great, and I'm with you that ideally they should be generic, like you mention, instead of protocol-specific like this.

"description": "The total number of records in the app.bsky.feed.post collection.",
"type": "integer",
"minimum": 0
}
}
}
}
},
Expand Down