-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an editor context menu to apply style to a word/selection #45
Draft
elazarcoh
wants to merge
1
commit into
jgclark:master
Choose a base branch
from
elazarcoh:apply-style-editor-context-menu
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Add an editor context menu to apply style to a word/selection #45
elazarcoh
wants to merge
1
commit into
jgclark:master
from
elazarcoh:apply-style-editor-context-menu
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elazarcoh
commented
Jan 12, 2022
Comment on lines
+396
to
+447
"default": [ | ||
{ | ||
"id": 1, | ||
"enabled": true, | ||
"backgroundColor": "#ffeb3b" | ||
}, | ||
{ | ||
"id": 2, | ||
"enabled": true, | ||
"backgroundColor": "#2196f3" | ||
}, | ||
{ | ||
"id": 3, | ||
"enabled": true, | ||
"backgroundColor": "#ff9800" | ||
}, | ||
{ | ||
"id": 4, | ||
"enabled": false, | ||
"backgroundColor": "#9c27b0" | ||
}, | ||
{ | ||
"id": 5, | ||
"enabled": false, | ||
"backgroundColor": "#2e7d32" | ||
}, | ||
{ | ||
"id": 6, | ||
"enabled": false, | ||
"backgroundColor": "#ff5722" | ||
}, | ||
{ | ||
"id": 7, | ||
"enabled": false, | ||
"backgroundColor": "#607d8b" | ||
}, | ||
{ | ||
"id": 8, | ||
"enabled": false, | ||
"backgroundColor": "#795548" | ||
}, | ||
{ | ||
"id": 9, | ||
"enabled": false, | ||
"backgroundColor": "#ffeb3b" | ||
}, | ||
{ | ||
"id": 10, | ||
"enabled": false, | ||
"backgroundColor": "#2196f3" | ||
} | ||
] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to edit the default styles.
(I didn't write those, I let copilot generate them for me)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an editor context menu entry for this extension.
It gave you the ability to quickly add/clear style to the selected word(s).
There're up to 10 different styles to choose from. To not make the menu too cluttered, the styles needs to be enabled from the settings. By default, only 3 styles will be enabled.
Due to VSCode limitations, there are some stuff that I would like to have, but they're impossible as far as I know.
It's mostly implemented. I need help setting up the default styles. See comment below.
fixes #44