Merge pull request #134 from jfrog/GH-133-fix-incorrect-field-name-fo…

…r-saml-auto-creation

Fix incorrect field name for saml auto creation

CHANGELOG.md

@@ -1,3 +1,13 @@
+## 1.13.0 (October 4, 2024). Tested on Artifactory 7.90.13 with Terraform 1.9.7 and OpenTofu 1.8.3
+
+NOTES:
+
+* resource/platform_saml_settings: `no_auto_user_creation` attribute is being deprecated in favor of `auto_user_creation`.
+
+BUG FIXES:
+
+* resource/platform_saml_settings: Fix `no_auto_user_creation` attribute has no effect. Replace it with new attribute `auto_user_creation` to match SAML Settings in the UI and REST API. Issue: [#133](https://github.com/jfrog/terraform-provider-platform/issues/133) PR: [#134](https://github.com/jfrog/terraform-provider-platform/pull/134)
+
 ## 1.12.0 (September 16, 2024). Tested on Artifactory 7.90.10 with Terraform 1.9.5 and OpenTofu 1.8.2
 
 FEATURES:

docs/resources/saml_settings.md

@@ -50,11 +50,12 @@ resource "platform_saml_settings" "my-okta-saml-settings" {
 
 - `allow_user_to_access_profile` (Boolean) When set, auto created users will have access to their profile page and will be able to perform actions such as generating an API key. Default value is `false`.
 - `auto_redirect` (Boolean) When set, clicking on the login link will direct users to the configured SAML login URL. Default value is `false`.
+- `auto_user_creation` (Boolean) When set, authenticated users are automatically created in Artifactory. When not set, for every request from an SSO user, the user is temporarily associated with default groups (if such groups are defined), and the permissions for these groups apply. Without automatic user creation, you must manually create the user inside Artifactory to manage user permissions not attached to their default groups. Default value is `true`.
 - `email_attribute` (String) If `no_auto_user_creation` is diabled or an internal user exists, the system will set the user's email to the value in this attribute that is returned by the SAML login XML response.
 - `enable` (Boolean) When set, SAML integration is enabled and users may be authenticated via a SAML server. Default value is `true`.
 - `group_attribute` (String) The group attribute in the SAML login XML response. Note that the system will search for a case-sensitive match to an existing group..
 - `name_id_attribute` (String) The username attribute used to configure the SSO URL for the identity provider.
-- `no_auto_user_creation` (Boolean) When disabled, the system will automatically create new users for those who have logged in using SAML, and assign them to the default groups. Default value is `false`.
+- `no_auto_user_creation` (Boolean, Deprecated) **Deprecated** Use `auto_user_creation` instead. When disabled, the system will automatically create new users for those who have logged in using SAML, and assign them to the default groups. Default value is `false`.
 - `sync_groups` (Boolean) When set, in addition to the groups the user is already associated with, he will also be associated with the groups returned in the SAML login response. Note that the user's association with the returned groups is not persistent. It is only valid for the current login session. Default value is `false`.
 - `use_encrypted_assertion` (Boolean) When set, an X.509 public certificate will be created by Artifactory. Download this certificate and upload it to your IDP and choose your own encryption algorithm. This process will let you encrypt the assertion section in your SAML response. Default value is `false`.
 - `verify_audience_restriction` (Boolean) Set this flag to specify who the assertion is intended for. The "audience" will be the service provider and is typically a URL but can technically be formatted as any string of data. Default value is `true`.