This repository has been archived by the owner on Aug 4, 2022. It is now read-only.
Add base structure for dev-1.0.0
#44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Feature/chart improvements
Setting the user that executes the actual `kubenab` application to a user that is not root. Running processes in containers as root is a security concern.
Change user in dockerfile to non-root user
This is because normal users don't need the benchark scripts, so when they are showing up in the GitHub UI/ Repository they disturbe more than helping.
This script will be used to automatically generaete the `README.md` - which is used by VuePress as `index.html`.
go.mod and go.sum should be in the root of a project. Since we will move a lot of files (ie. the Helm chart) out of this repository, the dependency management must be on top of the Project structure.
We are switching to are more convenient project structure layout and also replacing the `flag` library with `cobra`. This is because – maybe in the future – there will we a CLI to manage the kubenab configuration, getting stats, debugging ...
This helps to keep a more consistent and beatiful Makefile and also prevents code-resue (maybe in the future).
The new 'DEBUG' variable can now be enabled ('true') or
disabled ('false') which leads not only to setting the 'debug' tag but
also striping the debug informations from the resulting binary.
A `.editorconfig` file helps all contributors/ members keeping the same – consitent – Code layout.
Since those directories contains K8s templates to deploy `kubenab` we can remove them because those templates are generated – later – via `helm template`, even if the User does not deploy it via helm.
Since all test data are related to CI/CD – or local development – it "distributes" the clear view of the project.
The old documentation of the 'log' package was not conform to the GoDocs guidlines.
For more information checkout the body of Commit 002ee0b.
|
Since this is serves the base structure go get started could you review the changes @rimusz? |
The package 'log' now contains the default/ basic log functions of the logrus packge.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to keep track of the work which is related to #36
This PR will add some basic structures like: