Skip to content
This repository has been archived by the owner on Aug 4, 2022. It is now read-only.

[DISCUSSION] Roadmap to version 1.0.0 #36

Open
l0nax opened this issue Oct 16, 2019 · 26 comments
Open

[DISCUSSION] Roadmap to version 1.0.0 #36

l0nax opened this issue Oct 16, 2019 · 26 comments
Labels
documentation Improvements or additions to documentation
Milestone

Comments

@l0nax
Copy link
Contributor

l0nax commented Oct 16, 2019

Since I can not create a Milestone this Issue is a Request to create such a Milestone.

This Project uses Semantic Versioning and the "declaration" of Version 1.0.0 is that the Project is production ready. All Versions below 1.0.0 is "tagged" as breaking-changes may occur.

Here are some breaking Changes which I want to make to get this Project (really?) production-ready:

  • Documentation [Add Documentation Website #45]
    • Use the GitHub Pages Feature to serve a static HTML Documentation-Site
    • Document all available Features, Setup, Contribution, ...
    • The README.md is big and it would be better to split some parts in own Documentation Sections (Point Documentation -> 1 and 2)
  • Project Structure
    • changelog-go tool to maintain a consistent CHANGELOG.md
    • Currently the Project Structure isn't very nice (eg. the kubenab Source Code is under cmd/kubenab, K8s related things under deployment, chart, tls and webhook)
  • kubenab
    • Add CI/CD [Add CircleCi integration #42]
    • Secure/ Optimize Dockerfile/ resulting Image
      • non-root User
      • scratch Image
    • We are using the default log Library of golang (which isn't bad) but there are better/ faster libraries especially for Microservices
    • More Error Checking
    • Using (eg.) fasthttp instead of the default http Library of golang (=> faster)
    • *_test.go Fieles for Unit-Testing and Benchmarking of single Functions
    • Function, struct and Field Documentation
    • More Configuration possibilities (eg. per Namespace Config, etc..)
    • Add Xray Funktionality
    • Move helm chart to https://github.com/jfrog/charts [Move helm chart to https://github.com/jfrog/charts #43]

So @rimusz is this a good goal for Version 1.0.0?

@rimusz
Copy link
Contributor

rimusz commented Oct 16, 2019

@l0nax first thanks a lot for all your contributions to the project, we really appreciate it.

@rimusz rimusz added the documentation Improvements or additions to documentation label Oct 16, 2019
@l0nax
Copy link
Contributor Author

l0nax commented Oct 16, 2019

@rimusz Updated

Can you explain me what the Xray Feature is? As I understood it's a advanced Feature of the JFrog Artifactory.

@rimusz
Copy link
Contributor

rimusz commented Oct 16, 2019

JFrog Xray scans artefacts in Artifactory, by Xray feature I mean to implement https://github.com/jfrog/kubexray into Kubenab.
e.g. Kubenab checks image against Xray and if the image has security issues Kubenab will fail the image usage.

@l0nax
Copy link
Contributor Author

l0nax commented Oct 16, 2019

Ah ok.
Is the Xray API documentation public available?

@rimusz
Copy link
Contributor

rimusz commented Oct 16, 2019

@l0nax
Copy link
Contributor Author

l0nax commented Oct 16, 2019

Okay thanks

Could you create a Milestone and a develop branch? So we can keep track and other Users will have the stable Version of kubenab after cloning.

@rimusz rimusz added this to the version 1.0.0 milestone Oct 17, 2019
@rimusz
Copy link
Contributor

rimusz commented Oct 17, 2019

I have created the milestone and dev-1.0.0 branch

@l0nax
Copy link
Contributor Author

l0nax commented Oct 17, 2019

Thanks :)

@lhotrifork
Copy link
Contributor

Hi,
Is anybody working on this? There doesn't seem to be any activity on dev-1.0.0 branch
I'd love to help out in any way I can (also because I have some features that I would like to see :) ).

@l0nax
Copy link
Contributor Author

l0nax commented Jan 28, 2020

Hey @lhotrifork currently this project – especially release v1 – has a very high priority on our internal (and personal) Task list.

So if you have any ideas/ features please post it here so we can discuss about it :D

@l0nax
Copy link
Contributor Author

l0nax commented Feb 14, 2020

@rimusz could you please give me the privileges to push to the dev-1.0.0 branch? This would help me in my development cycle. But if it isn't possible it's not a big deal ^^

@l0nax
Copy link
Contributor Author

l0nax commented Feb 14, 2020

And whats about the CI/CD?
Which CI/CD service do you use? Is it possible that we can use Travis CI - since it's the defacto standard in OpenSource projects, also because everyone can check out the build logs, process, ...

@rimusz
Copy link
Contributor

rimusz commented Feb 14, 2020

@l0nax github does not support privileges per branch :(
We used TravisCI before but as JFrog acquired Shippable we have to use our products for CI/CD.
Let me double check that again.

@l0nax
Copy link
Contributor Author

l0nax commented Feb 14, 2020

@l0nax github does not support privileges per branch :(

Ok :(

Let me double check that again.

Ok, thanks :)

@l0nax
Copy link
Contributor Author

l0nax commented Feb 14, 2020

@rimusz Can the helm chart be split into a separate repository? Or ie. (later) into the JFrog Charts.

@rimusz
Copy link
Contributor

rimusz commented Feb 14, 2020

@l0nax yes, the chart will be moved to JFrog charts github repo

@l0nax
Copy link
Contributor Author

l0nax commented Feb 14, 2020

Started working on those features on dev-1.0.0 branch.

@l0nax
Copy link
Contributor Author

l0nax commented Feb 14, 2020

@rimusz Any updates about the Travis CI?

@rimusz
Copy link
Contributor

rimusz commented Feb 20, 2020

@l0nax I have no update on Travis Ci yet

@rimusz
Copy link
Contributor

rimusz commented Mar 10, 2020

@l0nax CircleCi will be used #42

@l0nax
Copy link
Contributor Author

l0nax commented Mar 10, 2020

Top, thanks @rimusz :)

@l0nax
Copy link
Contributor Author

l0nax commented Mar 10, 2020

I have now some "free" time so I will start integrating all those features – and update the chart, etc...

@l0nax
Copy link
Contributor Author

l0nax commented Mar 10, 2020

Should the things we discussed separated in different Issues (and linked here) to discuss about them and create PR's which are related to them? But keep the "global" discussion about v1 in this Issue.

@rimusz
Copy link
Contributor

rimusz commented Mar 10, 2020

Should the things we discussed separated in different Issues (and linked here) to discuss about them and create PR's which are related to them? But keep the "global" discussion about v1 in this Issue.

yes :)

@rimusz
Copy link
Contributor

rimusz commented Mar 10, 2020

I have now some "free" time so I will start integrating all those features – and update the chart, etc...

I will take care of CircleCI integration

@cprivitere
Copy link

cprivitere commented Jul 29, 2021

Just wondering if a path to 1.0.0 is still planned? Or did everyone jump ship to tugger or something?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

4 participants