Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Git Audit Command #221

Open
wants to merge 20 commits into
base: dev
Choose a base branch
from
Open

Git Audit Command #221

wants to merge 20 commits into from

Conversation

attiasas
Copy link
Contributor

@attiasas attiasas commented Nov 4, 2024

  • The pull request is targeting the dev branch.
  • The code has been validated to compile successfully by running go vet ./....
  • The code has been formatted properly using go fmt ./....
  • All static analysis checks passed.
  • All tests have passed. If this feature is not already covered by the tests, new tests have been added.
  • Updated the Contributing page / ReadMe page / CI Workflow files if needed.
  • All changes are detailed at the description. if not already covered at JFrog Documentation, new documentation have been added.

Depends on:

Add option to audit local Git repositories

  • Acts as a "wrapper" to audit command, adding the .git context to the audit.
  • Reports analytics to Git Repositories tab at JFrog platform

Other changes

  • Use empty Audit JAS test suite to accelerate the tests even more

@attiasas attiasas added new feature Automatically generated release notes safe to test Approve running integration tests on a pull request labels Nov 4, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Nov 4, 2024
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Nov 4, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Nov 4, 2024
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Nov 5, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Nov 5, 2024
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Nov 5, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Nov 5, 2024
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Nov 7, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Nov 7, 2024
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Nov 7, 2024
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Nov 7, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Nov 7, 2024
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Nov 7, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Nov 7, 2024
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Nov 10, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Nov 10, 2024
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Nov 10, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Nov 10, 2024
Copy link

👍 Frogbot scanned this pull request and did not find any new security issues.


Copy link

Merging this branch will not change overall coverage

Impacted Packages Coverage Δ 🤖
github.com/jfrog/jfrog-cli-security 0.00% (ø)
github.com/jfrog/jfrog-cli-security/cli 0.00% (ø)
github.com/jfrog/jfrog-cli-security/cli/docs 0.00% (ø)
github.com/jfrog/jfrog-cli-security/cli/docs/git/audit 0.00% (ø)
github.com/jfrog/jfrog-cli-security/cli/docs/git/contributors 0.00% (ø)
github.com/jfrog/jfrog-cli-security/commands/audit 0.00% (ø)
github.com/jfrog/jfrog-cli-security/commands/git/audit 0.00% (ø)
github.com/jfrog/jfrog-cli-security/commands/git/contributors 0.00% (ø)
github.com/jfrog/jfrog-cli-security/commands/scan 0.00% (ø)
github.com/jfrog/jfrog-cli-security/tests/utils 0.00% (ø)
github.com/jfrog/jfrog-cli-security/utils/git 0.00% (ø)
github.com/jfrog/jfrog-cli-security/utils/results 0.00% (ø)
github.com/jfrog/jfrog-cli-security/utils/xray/scangraph 0.00% (ø)
github.com/jfrog/jfrog-cli-security/utils/xsc 0.00% (ø)

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/jfrog/jfrog-cli-security/cli/cli.go 0.00% (ø) 0 0 0
github.com/jfrog/jfrog-cli-security/cli/docs/flags.go 0.00% (ø) 0 0 0
github.com/jfrog/jfrog-cli-security/cli/docs/git/audit/help.go 0.00% (ø) 0 0 0
github.com/jfrog/jfrog-cli-security/cli/docs/git/contributors/help.go 0.00% (ø) 0 0 0
github.com/jfrog/jfrog-cli-security/cli/gitcommands.go 0.00% (ø) 0 0 0
github.com/jfrog/jfrog-cli-security/cli/scancommands.go 0.00% (ø) 0 0 0
github.com/jfrog/jfrog-cli-security/commands/audit/audit.go 0.00% (ø) 0 0 0
github.com/jfrog/jfrog-cli-security/commands/audit/auditparams.go 0.00% (ø) 0 0 0
github.com/jfrog/jfrog-cli-security/commands/git/audit/gitaudit.go 0.00% (ø) 0 0 0
github.com/jfrog/jfrog-cli-security/commands/git/audit/gitauditparams.go 0.00% (ø) 0 0 0
github.com/jfrog/jfrog-cli-security/commands/git/contributors/countcontributors.go 0.00% (ø) 0 0 0
github.com/jfrog/jfrog-cli-security/commands/scan/scan.go 0.00% (ø) 0 0 0
github.com/jfrog/jfrog-cli-security/tests/utils/test_utils.go 0.00% (ø) 0 0 0
github.com/jfrog/jfrog-cli-security/utils/git/gitmanager.go 0.00% (ø) 0 0 0
github.com/jfrog/jfrog-cli-security/utils/git/gitutils.go 0.00% (ø) 0 0 0
github.com/jfrog/jfrog-cli-security/utils/results/results.go 0.00% (ø) 0 0 0
github.com/jfrog/jfrog-cli-security/utils/xray/scangraph/params.go 0.00% (ø) 0 0 0
github.com/jfrog/jfrog-cli-security/utils/xray/scangraph/scangraph.go 0.00% (ø) 0 0 0
github.com/jfrog/jfrog-cli-security/utils/xsc/analyticsmetrics.go 0.00% (ø) 0 0 0
github.com/jfrog/jfrog-cli-security/utils/xsc/xscmanager.go 0.00% (ø) 0 0 0

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/jfrog/jfrog-cli-security/audit_test.go
  • github.com/jfrog/jfrog-cli-security/commands/audit/audit_test.go
  • github.com/jfrog/jfrog-cli-security/commands/git/audit/gitaudit_test.go
  • github.com/jfrog/jfrog-cli-security/commands/git/contributors/countcontributors_test.go
  • github.com/jfrog/jfrog-cli-security/git_test.go
  • github.com/jfrog/jfrog-cli-security/utils/git/gitmanager_test.go
  • github.com/jfrog/jfrog-cli-security/utils/git/gitutils_test.go
  • github.com/jfrog/jfrog-cli-security/xsc_test.go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature Automatically generated release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant