New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove consolidatePaths from PackageFileFinder #143

Merged

Or-Geva merged 1 commit into jfrog:master from Or-Geva:PackageFileFinder

Nov 14, 2023

Contributor

Or-Geva commented Nov 14, 2023

All tests passed. If this feature is not already covered by the tests, I added new tests.

Due to the jfrog/jfrog-idea-plugin#435 pull request, we've already executed a consolidatePaths call before invoking PackageFileFinder at https://github.com/jfrog/jfrog-idea-plugin/pull/435/files#diff-2a45496f51bd41dcf256fb1bbc43f1bdc5940fd98e7c3a44f3f03209c69068aeR37.
To eliminate redundant function calls, we've removed the consolidatePaths call from PackageFileFinder.


          Remove consolidatePaths from PackageFileFinder

02b5c08

Or-Geva requested a review from yahavi

November 14, 2023 11:38

Or-Geva had a problem deploying to frogbot

November 14, 2023 11:38

— with

GitHub Actions Failure

yahavi approved these changes

View reviewed changes

Or-Geva merged commit 432db7c into jfrog:master

10 of 11 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet