review task tags

jflamy · Jul 25, 2024 · dbaa83e · dbaa83e
1 parent 7b4a798
commit dbaa83e
Show file tree

Hide file tree

Showing 7 changed files with 12 additions and 4 deletions.
diff --git a/owlcms/.settings/org.eclipse.jdt.core.prefs b/owlcms/.settings/org.eclipse.jdt.core.prefs
@@ -172,7 +172,7 @@ org.eclipse.jdt.core.compiler.release=enabled
 org.eclipse.jdt.core.compiler.source=17
 org.eclipse.jdt.core.compiler.storeAnnotations=disabled
 org.eclipse.jdt.core.compiler.taskCaseSensitive=enabled
-org.eclipse.jdt.core.compiler.taskPriorities=NORMAL,HIGH,HIGH
+org.eclipse.jdt.core.compiler.taskPriorities=NORMAL,HIGH,LOW
 org.eclipse.jdt.core.compiler.taskTags=TODO,FIXME,REVIEW
 org.eclipse.jdt.core.computeJavaBuildOrder=ignore
 org.eclipse.jdt.core.encoding=utf8

diff --git a/owlcms/src/main/java/app/owlcms/data/athlete/AthleteRepository.java b/owlcms/src/main/java/app/owlcms/data/athlete/AthleteRepository.java
@@ -148,7 +148,7 @@ public static List<Athlete> doFindFiltered(EntityManager em, String lastName, Gr
 		if (group != null && group.getName() == "*") {
 			group = null;
 		}
-		// FIXME this does not appear to work with ageDivision/Championship
+		// REVIEW this does not appear to work with ageDivision/Championship
 		String qlString = "select a from Athlete a"
 		        + filteringSelection(lastName, group, category, ageGroup, ageDivision, gender, weighedIn, team)
 		        + " order by a.category";

diff --git a/owlcms/src/main/java/app/owlcms/data/competition/Competition.java b/owlcms/src/main/java/app/owlcms/data/competition/Competition.java
@@ -421,6 +421,11 @@ synchronized public HashMap<String, Object> computeReportingInfo(String ageGroup
 	}
 
 	public void doGlobalRankings(List<Athlete> athletes, Boolean scoringSystemOnly) {
+		/*
+		 * TODO: make dependent on age group. age-group dependent would be for the registration category only (that shown on scoreboard and main medaling
+		 * for session). secondary medals for other eligibility categories would be computed separately, during reporting.
+		 */
+
 		//long beforeDedup = System.currentTimeMillis();
 		TreeSet<Athlete> noDup = new TreeSet<>(Comparator.comparing(Athlete::getFullId));
 		for (Athlete pAthlete : athletes) {

diff --git a/owlcms/src/main/java/app/owlcms/fieldofplay/FieldOfPlay.java b/owlcms/src/main/java/app/owlcms/fieldofplay/FieldOfPlay.java
@@ -2294,6 +2294,7 @@ private void recomputeOrderAndRanks(boolean recomputeCategoryRanks) {
 	}
 
 	private List<Athlete> updateScoringSystemRanking(EntityManager em, List<Athlete> l) {
+		//TODO: make scoringSystemRankings dependent on age group.
 		if (Competition.getCurrent().isDisplayScoreRanks()) {
 			// long beforeRanks = System.currentTimeMillis();
 			try {

diff --git a/owlcms/src/main/java/app/owlcms/nui/lifting/JuryDialog.java b/owlcms/src/main/java/app/owlcms/nui/lifting/JuryDialog.java
@@ -124,7 +124,7 @@ public void doClose(boolean noAction) {
 				this.close();
 				return;
 			}
-			// FIXME: this should be done after processing the JuryEvent in FieldOfPlay
+			// REVIEW: this should be done after processing the JuryEvent in FieldOfPlay
 			resumeLifting(noAction);
 
 			this.close();

diff --git a/owlcms/src/main/java/app/owlcms/nui/shared/NAthleteRegistrationFormFactory.java b/owlcms/src/main/java/app/owlcms/nui/shared/NAthleteRegistrationFormFactory.java
@@ -279,7 +279,7 @@ public Component buildNewForm(CrudOperation operation, Athlete aFromList, boolea
 		if (this.getCurrentGroup() != null && !this.getCurrentGroup().getName().equals("*")) {
 			aFromList.setGroup(getCurrentGroup());
 		}
-		this.binder.readBean(aFromList); // FIXME should be getEditedAthlete() ?
+		this.binder.readBean(aFromList); // REVIEW should be getEditedAthlete() ?
 
 		// binder has read bean.
 		filterCategories(getEditedAthlete().getCategory(), operation != CrudOperation.ADD);

diff --git a/src/main/markdown/ReleaseNotes.md b/src/main/markdown/ReleaseNotes.md
@@ -8,3 +8,5 @@
 - (beta01) Publicresults
   - When a user opens a scoreboard and a timer is running, the timer is now immediately synchronized
   - If the publicresults application is restarted, and sessions are in a break, the remaining time is now immediately synchronized
+
+See also [version 50 release notes](https://github.com/owlcms/owlcms4/releases/tag/50.0.0)