Skip to content

Commit

Permalink
Revert "e2e/test.sh: VenafiConnection CRDs weren't being installed"
Browse files Browse the repository at this point in the history
The error that I was trying to fix was:

 failed to list *v1alpha1.VenafiConnection: venaficonnections.jetstack.io
 is forbidden: User "system:serviceaccount:venafi:venafi-connection"
 cannot list resource "venaficonnections" in API group "jetstack.io" at
 the cluster scope

I then added crds.venafiConnection.include=true, thinking that the
agent's helm chart wasn't installing the RBAC.

But I found that ./hack/e2e/test.sh was installing venafi enhanced
issuer along with the Agent, which means the venafi-connection helm
chart was being installed and so crds.venafiConnection.include=true
isn't needed.
  • Loading branch information
maelvls committed Sep 26, 2024
1 parent 47b99ae commit 8c87b6c
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions hack/e2e/values.venafi-kubernetes-agent.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,3 @@ config:
authentication:
venafiConnection:
enabled: true

crds:
venafiConnection:
include: true

0 comments on commit 8c87b6c

Please sign in to comment.