Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added an extra validation for exp claims #2

Open
wants to merge 2 commits into
base: trunk-jba+jbt
Choose a base branch
from
Open

added an extra validation for exp claims #2

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cae6a19
added an extra validation for exp claims
kutafia Dec 2, 2020
fd0f2ae
applied suggested fixes
kutafia Dec 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions lambda/lambda.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,12 @@ async function handler(request) {
return;
}
console.log(jwtKey.modeName + ": payload " + JSON.stringify(payload, null, ' '));
// JBA id tokens are valid for an hour and JBT ones for 10 minutes, so the common threshold is set at 3600 seconds
if (Math.floor(Date.now() / 1000) + 3600 < payload.exp) {
kutafia marked this conversation as resolved.
Show resolved Hide resolved
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I do the match right - 1 hour = 3600 seconds. We a change (thanks to time drift) to see a token that is exactly 1 hour to live, so the test would not pass. Please tell me if you could set a longer time-bound here, just in case, say 2 hours?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this code is safe for time zones? I'm not sure about Date.now() and payload.exp in that respect.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess 2 hours is a large enough boundary, especially when Space's tokens are valid for 10 minutes only :)
Indeed, it is better to validate if the difference between iat and exp claims is greater then 7200 seconds. We will surely be time zone independent then.

console.log(jwtKey.modeName + ': "Expiration time" (exp) claim is too far in the future');
resolve(false);
return;
}
resolve(jwtKey.verifyCallback(payload));
});
});
Expand Down