Fix warning and empty hash #18
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes stream is read even after reaching eof. In this case hash_final is called on obsolete hashResource producing warning and destroys hash result. Checking that hash is null prevents this behavior. User still can seek(0) and set hash to null in initializeHash function. Use case: AesDecryptingStream:113 calls read on empty stream (in our case its HashingStream) in order to prefetch data. Results: * Warning is produced. * Hash is spoiled.
Codecov Report
@@ Coverage Diff @@
## master #18 +/- ##
===========================================
Coverage 100.00% 100.00%
- Complexity 113 114 +1
===========================================
Files 12 12
Lines 300 301 +1
===========================================
+ Hits 300 301 +1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes stream is read even after reaching eof.
In this case hash_final is called on obsolete hashResource producing warning and destroys hash result.
Checking that hash is null prevents this behavior.
User still can seek(0) and set hash to null in initializeHash function.
Use case:
AesDecryptingStream:113 calls read on empty stream (in our case its HashingStream) in order to prefetch data.
Results: