Make eof() consider padding when reading less than block size

jeskew · Apr 12, 2020 · ef67d7b · ef67d7b
1 parent 432b7b9
commit ef67d7b
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 0 deletions.
diff --git a/src/AesEncryptingStream.php b/src/AesEncryptingStream.php
@@ -93,6 +93,11 @@ public function seek($offset, $whence = SEEK_SET): void
         }
     }
 
+    public function eof(): bool
+    {
+        return $this->stream->eof() && !strlen($this->buffer);
+    }
+
     private function encryptBlock(int $length): string
     {
         if ($this->stream->eof()) {

diff --git a/tests/AesEncryptingStreamTest.php b/tests/AesEncryptingStreamTest.php
@@ -216,4 +216,24 @@ public function seek(int $offset, int $whence = SEEK_SET): void {}
 
         $this->assertRegExp("/EncryptionFailedException: Unable to encrypt/", $error);
     }
+
+    /**
+     * @dataProvider cipherMethodProvider
+     *
+     * @param CipherMethod $cipherMethod
+     */
+    public function testEofShouldConsiderPaddingWhenReadSizeIsLessThenBlockSize(CipherMethod $cipherMethod)
+    {
+        $stream = new AesEncryptingStream(
+            new RandomByteStream(100),
+            self::KEY,
+            $cipherMethod
+        );
+        $expectedSize = $stream->getSize();
+        $actualSize = 0;
+        while (!$stream->eof()) {
+            $actualSize += strlen($stream->read(15));
+        }
+        $this->assertSame($expectedSize, $actualSize);
+    }
 }