Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SMTPS notify #1556

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Add SMTPS notify #1556

wants to merge 5 commits into from

Conversation

popexie
Copy link

@popexie popexie commented Oct 21, 2024

Description

Checklist

  • I have reviewed the contributing guidelines.
  • I have included unit tests for my changes or additions.
  • I have successfully run make test-docker with my changes.
  • I have manually tested all relevant modes of the change in this PR.
  • I have updated the documentation.
  • I have updated the changelog.

Questions or Comments

@jertel
Copy link
Owner

jertel commented Oct 21, 2024

Thanks for your contribution. I don't think this is needed any longer. Did you see the new feature that was added a few weeks ago? It allows any of the built-in alerters to be used for notifications. That then allows the ability to send emails over SMTPS/TLS/etc.

@popexie
Copy link
Author

popexie commented Nov 11, 2024

This patch is not for rule notification. This is for sending notification of ElastAlert2 itself.

@jertel
Copy link
Owner

jertel commented Nov 11, 2024

The change I mentioned earlier is not for rule notification. It's for system error notifications. Please see the latest CHANGELOG.md.

@popexie
Copy link
Author

popexie commented Nov 20, 2024

Please check function send_notification_email in elastalert.py. It does not support SMTPS.

@jertel
Copy link
Owner

jertel commented Nov 20, 2024

image
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants