-
Notifications
You must be signed in to change notification settings - Fork 474
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Making filtering text inputs easy / simple again #61
base: master
Are you sure you want to change the base?
Conversation
This is de-facto a revert of the pull request "jeresig#54 from abolishme/patch-1" and follow-up commits, while also clarifying how the original code was meant and bringing back some "reasonable defaults". Plus fixing related (structure) typos in the README file.
Note that the I have left the Note 2: In the very original forked repository, one can see that these input elements were always filtered: |
I think we need some tests here. The reason the option exists is because some users have asked for it (for better or worse). |
OK, so is this project completely abandoned by the maintainers? The latest commits and documentation I tried to fix with this PR, together with wrong tagging (see 58038e6#diff-5736fc95626e37d54f44e395ad7aea8120507f84525485498a7d909db88a9e72) left this project in a very messy state, IMO. It looks like maintaining another fork is the only way to go now? |
I'll be reviewing this and the previous PR over the next few days to consider this PR and possibly release a new version of the library. |
@rpocklin, thank you, I've left the feedback at the new PR. I hope you still have time? Anyway, I guess you can close this PR then. |
This is de-facto a revert of the pull request "#54 from
abolishme/patch-1" (see the discussion there) and follow-up commits, while also clarifying how the
original code was possibly meant and bringing back some "reasonable defaults".
Plus fixing related (structure) typos in the README file.