[JENKINS-73944] Extract inline event handler from POSTHyperlinkNote (…

…#284)
jenkinsci · Oct 16, 2024 · dc0c358 · dc0c358
1 parent f8d41ac
commit dc0c358
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/src/main/java/org/jenkinsci/plugins/workflow/support/steps/input/POSTHyperlinkNote.java b/src/main/java/org/jenkinsci/plugins/workflow/support/steps/input/POSTHyperlinkNote.java
@@ -83,7 +83,7 @@ public POSTHyperlinkNote(String url, int length) {
 
     @Override protected String extraAttributes() {
         // TODO perhaps add hoverNotification
-        return " onclick=\"fetch(decodeURIComponent(atob('" + encodeForJavascript(url) + "')), { method: 'post', headers: crumb.wrap({})}); return false\"";
+        return " data-encoded-url='" + encodeForJavascript(url) + "' class='post-hyperlink-note-button'";
     }
 
     /**

diff --git a/.../resources/org/jenkinsci/plugins/workflow/support/steps/input/POSTHyperlinkNote/script.js b/.../resources/org/jenkinsci/plugins/workflow/support/steps/input/POSTHyperlinkNote/script.js
@@ -0,0 +1,10 @@
+Behaviour.specify("A.post-hyperlink-note-button", "POSTHyperLinkNote", 0, function (element) {
+    element.addEventListener("click", (event) => {
+        event.preventDefault();
+        const url = decodeURIComponent(atob(element.dataset.encodedUrl));
+        fetch(url, {
+            method: "post",
+            headers: crumb.wrap({}),
+        });
+    });
+});