Fixes: JENKINS-71794 Redesign build queue | UX #339
Conversation
Layout change of "Build Executor Status" as mentioned in bug JENKINS-71794.
The screenshots confused me initially because they are showing different states (one with two executors busy, one with one busy and one idle). Would be clearer to show a pair of before and after screenshots adjusting only the software version but otherwise displaying identical executor data. |
| <j:if test="${rAuth != null}"> | ||
| <a href="${rootURL}/${r.url}" class="model-link inside"><l:breakable value="${r.displayName}"/></a> | ||
| <st:nbsp/> | ||
| <div> | ||
| <j:set var="label" value="${it.parent.enclosingLabel}"/> |
There was a problem hiding this comment.
You are changing the logic for when this part is visible (depending on rAuth), which may introduce a security regression (displaying possibly sensitive information to unauthorized or anonymous users).
There was a problem hiding this comment.
@jglick I see, it does make sense to add a check for rAuth. Currently I have added a conditional statement for label so I'll also have to add an conditional statement if rAuth != null as well. That way user will only be able to see label if user is authorized and label is not equal to null. Am I correct?
There was a problem hiding this comment.
Something like that. Just ensure that the authorization logic is identical to the previous state.
|
jenkinsci/jenkins#8459 (comment) applies here as well. |
Added conditional statement to show label only if the user is Authorized and label != null.
Fixes: JENKINS-71794
The current build queue layout contains a lot of unnecessary free space. Refer JENKINS-71794 for more details.
The changes are implemented in both PR:core as well as PR:workflow-durable-task-step-plugin to maintain consistency in design. But if any downgraded version of core is used then user will still see the inconsistency in design as shown in second image.
Testing done
This is how it'll display if used with downgraded core version.
Submitter checklist