Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-73969] [JENKINS-73970] Remove inline JavaScript to become CSP compliant #72

Merged
merged 8 commits into from
Oct 16, 2024

Conversation

mawinter69
Copy link
Contributor

@mawinter69 mawinter69 commented Aug 28, 2024

use checkDependsOn for checkUrl
move the script for UserRelevanceFilter to a separate js file and load as adjunct
fix that nameOptions were not hidden when when selecting a non name matcher in regex filter

Testing done

Manual Testing

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

use checkDependsOn for checkUrl
move the script for UserRelevanceFilter to a separate js file and load
as adjunct
@mawinter69 mawinter69 requested a review from a team as a code owner August 28, 2024 17:05
@jglick jglick enabled auto-merge October 16, 2024 18:48
@basil basil disabled auto-merge October 16, 2024 19:03
@basil basil changed the title remove inline javascript to become CSP compliant [JENKINS-73969] [JENKINS-73970] Remove inline javascript to become CSP compliant Oct 16, 2024
@basil basil changed the title [JENKINS-73969] [JENKINS-73970] Remove inline javascript to become CSP compliant [JENKINS-73969] [JENKINS-73970] Remove inline JavaScript to become CSP compliant Oct 16, 2024
Copy link
Member

@basil basil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much!

@basil basil enabled auto-merge (squash) October 16, 2024 20:29
@basil basil merged commit 2c0a4dd into jenkinsci:master Oct 16, 2024
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants