feat(AritfactDeployer): Record deployments for use in plugins and via API #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows programmatic access to the maven metadata and the download url.
Running the tests was failing under JDK 17, so the test harness (brought in by the bom and parent plugin) needed to be updated. After the update, the TokenMacro tests failed until slightly bumping the token-macro dep.
credentialsId is defined on the repository (referenced by repositoryId), not on the ArtifactDeployer.
The artifact/metadata file is a tmp file that has no bearing on what gets deployed
the local path does not have the deployed file name
the previous attempt could not relativize the paths because they are both "absolute".
The action class needs to be serializable, but RepositoryLayoutProvider is not. So, move the responsibility up into the recorder.
use basically the same logic as Artifact.
copartdevops
force-pushed
the
record_deployments
branch
from
b4bde02
to
562cc83
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When deploying a
-SNAPSHOTbuild, I need a way to look up what the resolved version and the deployed artifact's file name when ArtifactDeployer deploys it to the remote repository.So, this PR adds machinery to allow recording deployments on the Build object via an InvisibleAction. This will show up in API calls, and will be available for use by other plugins.
Also, I had issues running tests locally under JDK 17, so I bumped the jenkins version to the oldest still-supported LTS releas.
This is not related to any Jira issues.
Built on top of #62 , so that should be merged first.
Testing done
For tests, it's not clear how to mock out the interactions with the aether library during deployment. Do you have any hints on how to test deployment?
I've manually tested by running a job and inspecting the output of
job/<job>/build/<number>/api/json?pretty=trueto ensure the artifacts are recorded as expected.Submitter checklist