Add job start and duration time to job page #458
Conversation
mr-remington
force-pushed
the
add-job-start-and-duration-time
branch
from
57c58e1 to
3a508f8
Compare
There was a problem hiding this comment.
Hey I've pushed a few changes so it doesn't take up as much room, let me know what you think.
I've left some inline comments or TODOs in the code where it could be improved
FYI I'll be away for ~2 weeks or so in a few hours and I won't merge this before leaving as I don't want to be not around in case there's an issue.
|
|
||
| SimpleDateFormat sdf = new SimpleDateFormat("d MMM, hh:mm", Locale.getDefault()); | ||
| // TODO support user timezones from UserProperty | ||
| sdf.setTimeZone(TimeZone.getDefault()); |
There was a problem hiding this comment.
Users are able to set their own timezone in their user configuration, it would be good to support this, and also the Jenkins timezone property won't be supported by this core Java feature.
There was a problem hiding this comment.
Agreed I would have much rather passed epoch into RunInfo, also respecting a users preference for clock notation(12/24) but that information isn't bubbled up to this plugin yet..
| // TODO support user timezones from UserProperty | ||
| sdf.setTimeZone(TimeZone.getDefault()); | ||
| // TODO display full duration on hover but continue shortened for display | ||
| this.startTime = sdf.format(new Date(run.getStartTimeInMillis())); |
There was a problem hiding this comment.
I think there was too much info there before, I've shortened it but it would be good to show the full version on hover (ideally client side formatted I just didn't have much time)
| <p>{run.displayName}</p> | ||
| </a> | ||
| <div className="PWGx-Start"> | ||
| <span>{run.startTime} - {jobStatus === "in_progress" ? "Running..." : run.duration}</span> |
There was a problem hiding this comment.
I think it would be good to move this out to its own 'chip' but I wasn't able to make it work in the 10mins or so I had (the display flex column wants each on their own line)
this is probably ok though
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
...o/jenkins/plugins/pipelinegraphview/multipipelinegraphview/MultiPipelineGraphViewAction.java
Fixed
Show fixed
Hide fixed
|
Any help needed to move this forward? |
|
Closing due to age. Will revisit |
This PR adds the job start time and job duration to the table view on the jobs page along with minor formatting to make it cleaner and easier to use:
For the ID column custom displayNames are accounted for w ellipsis cutoff. This PR addresses issue #449. Note I made some minor cleanups from the screenshot in the issue. Here is the final view:
Submitter checklist