-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Try adding windows build #496
Conversation
"MSI=${WORKSPACE}/jenkins.msi", | ||
"RELEASELINE=-experimental", | ||
]) { | ||
powershell ".\\make.ps1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So while this works its not the same image as run in the windows build currently.
https://github.com/jenkins-infra/release/blob/master/Jenkinsfile.d/core/package#L259
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a way to use the same pod template from the release repo? Is the pod template for the Linux build the same as used in release?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It inherits something similar I think but not quite the same, but cc @dduportal
Container image is passed here:
Line 16 in 5100d16
containerTemplate(name: 'jnlp', image: 'jenkinsciinfra/packaging:latest') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good grief @timja . However, given how slow the Windows pod are to spin up (the dotnet SDK container takes 12 to 17 min to pull and AKS does not allow nodes to come with container images preloaded AFAIK), I would not mind using a Windows (2022?) VM with the same template as in ci.jio.
@slide does the current docker-windows
work? if yes, we can totally set up release to use the same.
The only important part is the timing: we need to sync the PR change here with the release agent definition change to avoid breaking next release
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
docker-windows
is using the packer image setup, is that correct? Also, I am not sure if it works, I don't have access to test my Jenkinsfile changes on CI as I am not part of the packaging repo team.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do I just request access via helpdesk?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do I just request access via helpdesk?
Ideally yes: it is easier to audit afterwards. We tend to also ask in jenkins dev mailing list to have +1 (to gather community feedbacks) as an unspoken but usual rule, to get a quorum.
That should be a quick one
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I sent an email to the developers list and got some +1's: https://groups.google.com/g/jenkinsci-dev/c/U5WoCd77wuo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added permission, I think you will need to create a new PR for the Jenkinsfile change to work
Try adding a windows build
Testing done
Submitter checklist
Fixes #235