Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Try adding windows build #496

Closed
wants to merge 2 commits into from
Closed

Conversation

slide
Copy link
Member

@slide slide commented Dec 4, 2024

Try adding a windows build

Testing done

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

Fixes #235

@slide slide requested a review from a team as a code owner December 4, 2024 23:54
"MSI=${WORKSPACE}/jenkins.msi",
"RELEASELINE=-experimental",
]) {
powershell ".\\make.ps1"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So while this works its not the same image as run in the windows build currently.

https://github.com/jenkins-infra/release/blob/master/Jenkinsfile.d/core/package#L259

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a way to use the same pod template from the release repo? Is the pod template for the Linux build the same as used in release?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It inherits something similar I think but not quite the same, but cc @dduportal

Container image is passed here:

containerTemplate(name: 'jnlp', image: 'jenkinsciinfra/packaging:latest')

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good grief @timja . However, given how slow the Windows pod are to spin up (the dotnet SDK container takes 12 to 17 min to pull and AKS does not allow nodes to come with container images preloaded AFAIK), I would not mind using a Windows (2022?) VM with the same template as in ci.jio.

@slide does the current docker-windows work? if yes, we can totally set up release to use the same.

The only important part is the timing: we need to sync the PR change here with the release agent definition change to avoid breaking next release

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docker-windows is using the packer image setup, is that correct? Also, I am not sure if it works, I don't have access to test my Jenkinsfile changes on CI as I am not part of the packaging repo team.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do I just request access via helpdesk?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do I just request access via helpdesk?

Ideally yes: it is easier to audit afterwards. We tend to also ask in jenkins dev mailing list to have +1 (to gather community feedbacks) as an unspoken but usual rule, to get a quorum.

That should be a quick one

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I sent an email to the developers list and got some +1's: https://groups.google.com/g/jenkinsci-dev/c/U5WoCd77wuo

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added permission, I think you will need to create a new PR for the Jenkinsfile change to work

@slide slide closed this Dec 6, 2024
@slide slide deleted the add_windows branch December 6, 2024 03:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add MSI build to Jenkinsfile
3 participants