Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looking at sources I noticed that a lot of mojo parameters and helper methods were defined in an unnecessarily high superclass (used only in a specific subclass). Trying to push down things into more appropriate places.
Also removing gratuitous getter/setter pattern in favor of simple fields (https://maven.apache.org/guides/plugin/guide-java-plugin-development.html#defining-parameters-within-a-mojo clarifies that the JavaBeans pattern is an option helpful for integrating with other code, which is not relevant in this context) and limiting Java access to
private
orprotected
as appropriate.AbstractJenkinsMojo
AbstractHpiMojo
AbstractJenkinsManifestMojo