Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get optional plugins into hpi:run #43

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

KostyaSha
Copy link
Member

@KostyaSha KostyaSha commented Nov 11, 2016

Loaded additional plugins into work/plugins, but seems failed because of versions. I.e.

Failed Loading plugin Jenkins promoted builds plugin v2.27 (promoted-builds)
java.io.IOException: Jenkins promoted builds plugin v2.27 failed to load.
 - maven-plugin v2.0 is missing. To fix, install v2.0 or later.
 - Script Security Plugin v1.13 is older than required. To fix, install v1.16 or later.
 - Job DSL v1.38 is older than required. To fix, install v1.44 or later.

Any comments how to get optional deps for deps of hpi:run'ed plugin are welcome


This change is Reviewable

@KostyaSha
Copy link
Member Author

@jglick @stephenc do you have any ideas?

@stephenc
Copy link
Member

Oh that's going to end up a hack fest very quickly... you probably have duplicate GAs with different Vs from walking the whole tree to recover the optionals...

You'all have to do a depth priority collection and pick the highest version for non-unique artifacts (remembering that when one gets evicted because its not the latest then you also need to evict all that the evicted dependency pulled in)

(Which explains some of the logic of PDTs in my Maven 5.0.0 proposal I am working on)

@KostyaSha
Copy link
Member Author

Collect all highest plugin numbers... may work...

@stephenc
Copy link
Member

Until it doesn't... and if dependency trees change from version to version you'll pull in incorrect deps

@jglick jglick changed the title WIP Attempt to get optional plugins into hpi:run Get optional plugins into hpi:run Dec 16, 2016
@jglick
Copy link
Member

jglick commented Oct 5, 2021

I do not recall ever having had this problem. Would it not suffice to add test-scoped dependencies on transitive deps as a workaround?

@jglick jglick marked this pull request as draft November 3, 2021 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants