-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JENKINS-60517] Add null check for containerWorkingDirFilePath #671
Conversation
|
@k2glyph This is the same exception reported in the jenkins issue which was addressed as part of this PR. Do you still see the issue with the changes in this PR? If so, a sample JenkinsFile to reproduce the issue would help reproducing the issue. |
assertFalse(templates.isEmpty()); | ||
PodTemplate template = templates.get(0); | ||
assertEquals(Integer.MAX_VALUE, template.getInstanceCap()); | ||
r.assertBuildStatusSuccess(r.waitForCompletion(b)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is currently failing for me locally in Microk8s (noticed while testing #1083); the build fails in docker run
with
docker: Error response from daemon: cgroups: cgroup mountpoint does not exist: unknown.
Perhaps because Microk8s is now using cgroup v2, and docker:19-dind
is assuming v1? Need to figure out how to Assume
that the environment is capable of running DinD pods, at least with the specified image version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also failing locally when I run tests in #1275, but apparently not in CI.
NPE happens when shell command gets executed inside a dynamically created container inside a DIND container. As this shell command is getting executed with in a container created outside of kubernetes pod, container working directory is getting set to null. Added a null check to avoid NPE.
Check https://issues.jenkins-ci.org/browse/JENKINS-60517 for more details