Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JENKINS-67196] Pods are terminated after ~110s and ignore PodTemplate.connectionTimeout when containers start #1077

Merged
merged 1 commit into from
Nov 24, 2021
Merged

[JENKINS-67196] Pods are terminated after ~110s and ignore PodTemplate.connectionTimeout when containers start #1077

merged 1 commit into from
Nov 24, 2021

Conversation

Vlatombe
Copy link
Member

@Vlatombe Vlatombe commented Nov 24, 2021 •
edited
Loading

JENKINS-67196

Amends #1050
Partially revert f95a604, as it was not honoring long timeouts anymore.

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@Vlatombe
[JENKINS-67196] Partially revert f95a604
c00b11b 
It was not honoring long timeouts anymore.
@Vlatombe Vlatombe added the bug Bug Fixes label Nov 24, 2021
@Vlatombe Vlatombe changed the title [JENKINS-67196] Partially revert f95a6044 [JENKINS-67196] Pods are terminated after ~110s and ignore PodTemplate.connectionTimeout when containers start Nov 24, 2021
@Vlatombe Vlatombe merged commit 3074920 into jenkinsci:master Nov 24, 2021
@Vlatombe Vlatombe deleted the JENKINS-67196 branch November 24, 2021 13:49
@jglick
Copy link
Member

jglick commented Dec 8, 2021

Even after this, the errorPod test takes me ~120s to run, which is close to the test timeout.

@jglick
Copy link
Member

jglick commented Dec 8, 2021

(Reliably timing out in #1083 but that is looking like a regression in that PR; reason still unclear.)

jglick added a commit to jglick/kubernetes-plugin that referenced this pull request Dec 8, 2021
@jglick
Delaying Reaper.activate seems to help? jenkinsci#1077 (comment)
0f00e23
@caylorme
Copy link

Thank you @jglick for calling out that regression and fixing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Bug Fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Vlatombe @jglick @caylorme