Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: change default value for configurationAsCode and groovyScripts #947

Merged
merged 1 commit into from
Jan 7, 2024

Conversation

mashchensky
Copy link

Changes

Change default value for configurationAsCode and groovyScripts to remove warning on Helm chart installation.

coalesce.go:286: warning: cannot overwrite table with non table for jenkins-operator.jenkins.configuration.configurationAsCode (map[])
coalesce.go:286: warning: cannot overwrite table with non table for jenkins-operator.jenkins.configuration.groovyScripts (map[])

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

Reviewer Notes

If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS.

Copy link
Collaborator

@brokenpip3 brokenpip3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution

@brokenpip3 brokenpip3 merged commit 2ba5334 into jenkinsci:master Jan 7, 2024
4 checks passed
AniketNS pushed a commit to AniketNS/kubernetes-operator that referenced this pull request Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants