Provides an Override to the WATCH_NAMESPACE env variable. #923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brokenpip3
reviewed
Nov 12, 2023
| @@ -57,6 +57,8 @@ spec: | |||
| - name: WATCH_NAMESPACE | |||
| {{- if .Values.jenkins.enabled }} | |||
| value: {{ .Values.jenkins.namespace }} | |||
| {{- else if .Values.operator.watchNamespace }} | |||
There was a problem hiding this comment.
Please add this option in values.yaml but commented with a short explanation on how to use it. Thanks
valenca
force-pushed
the
fix-922-watch-namespace-override
branch
from
863c217 to
06992a4
Compare
|
The test are failing for another reason, I will fix it so you can merge master in this branch e we can merge the PR. |
|
Can you merge/rebase master in this PR? |
added 3 commits
November 19, 2023 14:22
In case the Jenkins instance is disabled, this commit allows us to pick a different namespace for the deployment by configuring the operator object instead of the jenkins object.
valenca
force-pushed
the
fix-922-watch-namespace-override
branch
from
06992a4 to
19d936d
Compare
brokenpip3
approved these changes
Feb 4, 2024
|
Thanks for your contribution |
AniketNS
pushed a commit
to AniketNS/kubernetes-operator
that referenced
this pull request
Feb 6, 2024
) Co-authored-by: João Valença <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case the Jenkins instance is disabled, this commit allows us to pick a different namespace for the deployment by configuring the operator object instead of the jenkins object.
Changes
Adds a new operator.watchNamespace value that should be used in case jenkins.enabled is set to false.
Updates and cleans up the documentation to reflect this change.
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Reviewer Notes
If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS.
Release Notes