Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combine dark and regular logo in README.md #915

Merged
merged 1 commit into from
Oct 15, 2023
Merged

Combine dark and regular logo in README.md #915

merged 1 commit into from
Oct 15, 2023

Conversation

pyatizbyantsevia
Copy link

@pyatizbyantsevia pyatizbyantsevia commented Oct 5, 2023

Changes

Since the paths between the repositories to assets/ are different, the working version can be viewed on the master branch of my fork.

It might be worth creating a logo in .svg format so as not to have 2 files and encapsulate all the logic inside the svg, as in design-library-plugin

To check the functionality, you can open two tabs: master branch in my fork, appearance settings. By switching the style on the appearance tab and then refreshing the fork page, you can see the functionality

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

Reviewer Notes

If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS.

Release Notes

Describe any user facing changes here, or delete this block.

Examples of user facing changes:
- API changes
- Bug fixes
- Any changes in behavior

@pyatizbyantsevia
Copy link
Author

pyatizbyantsevia commented Oct 5, 2023

If this PR is accepted, then before the merge I would be very grateful if there was a label for Hacktoberfest (hactoberfest-accepted)

@pyatizbyantsevia
Copy link
Author

@brokenpip3, could you take a look?

@brokenpip3
Copy link
Collaborator

Yes, sorry will take a look during this week

@brokenpip3 brokenpip3 merged commit 3682468 into jenkinsci:master Oct 15, 2023
1 check passed
@brokenpip3
Copy link
Collaborator

thanks for your contribution

@pyatizbyantsevia
Copy link
Author

Thank you! Sorry, I made a mistake in the label name, it should be "hacktoberfest-accepted", missed the 'k'.
Thanks again!

@brokenpip3
Copy link
Collaborator

done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants