fix(master): pass lifecycle configuration to master container

[DionJones615]

Changes

Simply passed the lifecycle defined in the Jenkins CRD down to the generated pod definition. The necessary bits appear to already be in the CRD.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

• Includes tests (if functionality changed/added)
• Includes docs (if user facing)
• Commit messages follow commit message best practices

See the contribution guide for more details.

Reviewer Notes

If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS.

Release Notes

Describe any user facing changes here, or delete this block.

Examples of user facing changes:
- API changes
- Bug fixes
- Any changes in behavior

[brokenpip3]

ehi @DionJones615 thanks for your contribution.

I think here we miss:

• a guard if lifecycle is empty
• the option listed in the helm chart values and jenkins template

wdyt?

thanks

[DionJones615]

@brokenpip3 Sorry, priorities shifted for a minute. :) How's this looking? Working well in my tests

[brokenpip3]

Nice, ty for coming back and try to complete the PR!

did you tried locally with a binary build from this PR to pass a lifecycle? I wish we can add a test, at least here. If everything is green after that we can merge it :)

[DionJones615]

Nice, ty for coming back and try to complete the PR!

did you tried locally with a binary build from this PR to pass a lifecycle? I wish we can add a test, at least here. If everything is green after that we can merge it :)

Yep, we're about to push it to prod to improve the shutdown process, keeping the jenkins container open with quietDown enabled for better communication with users about shutdown processes, especially when the backup/restore takes a bit of time.

Test added 🤞

[brokenpip3]

perfect, thanks for your contribution!