[WIP] Road to version 9.0: Updated go version to 1.22 & Fixed Breaking Changes ✨

[ansh-devs]

Changes

• Updated GO version to 1.22.
• Updated deprecated WebhookServer And CacheNamespace configurations to use the updated controller-runtime.
• Refactored configMapResource in jenkinsController.
• Makefile Indentation fixed.
• Nix Builds unresolved dependencies fixed. (Now checks are successfully passing).
• Updated golangci-lint version to [email protected].
• Updated Mocks for pkg/controller/jenkins/client/jenkins.go to support new changes.
• Update E2E tests and make them compatible with new changes.

Pending changes

• Update HELM tests and make them compatible with new changes.

NOTE

• As of now only one change has been made in .github/workflows that is to exclude go.sum from Codespell

View Patch

[brokenpip3]

wow great work in few days so far! 👏 🚀

let's remove the prealloc linter from the golanci-lint config temporary so we can see what is the status of the e2e tests :)

Checking the bats logs I saw some issues but let's make sure that the e2e tests are working first, I can help in case of issues since I have the deep knowledge of those tests, so let me know in case you will face something odd :)

[ansh-devs]

Sure, Iet's go with that

[brokenpip3]

I see great progress :)

to fix the latest issues can you update the controller gen version?
Taking a quick look should be something like:

-KUSTOMIZE_VERSION ?= v3.8.7
-CONTROLLER_TOOLS_VERSION ?= v0.9.2
+KUSTOMIZE_VERSION ?= v5.3.0
+CONTROLLER_TOOLS_VERSION ?= v0.14.0

we probably also need to change the envtest version and installation method but it's not critical now

[ansh-devs]

I see great progress :)

to fix the latest issues can you update the controller gen version? Taking a quick look should be something like:

-KUSTOMIZE_VERSION ?= v3.8.7
-CONTROLLER_TOOLS_VERSION ?= v0.9.2
+KUSTOMIZE_VERSION ?= v5.3.0
+CONTROLLER_TOOLS_VERSION ?= v0.14.0

we probably also need to change the envtest version and installation method but it's not critical now

seems to be an type check errors issue among packages I will look into it !

[ansh-devs]

@brokenpip3 Have you checked it

[brokenpip3]

ehi @ansh-devs unfortunately no, I still need to do it.
I usually try to cover one or two weekends to work on oss projects but so far I was not able to do it, 'cause life.
I will try to do my best in the following weeks, don't worry, soon or later I will put the proper effort like I did in the past 2 years :)
I'm sorry if your PRs is blocked by me but right now I can't do more than this.

[ansh-devs]

Sure take your time😃

[ansh-devs]

Hi @brokenpip3, are there any breaking changes due to upgrade ?

[brokenpip3]

No no nothing :)
I was just bumping to exclude other issues for the tests, I'm positive that soon I will have one day to dedicate to find the failures and unblock this PR and the migration epic :)

[brokenpip3]

I started to take a look, it seems that the reconcile loop is broken while applying the "base configuration" snippets.
Will continue to dig and push some changes

[brokenpip3]

we are in a better shape but still there are several things that needs to be fixed before merging

[ansh-devs]

let me know if there is anything for me to do

[brokenpip3]

Thanks I will check the failing tests since I have more context. If you want (but really if you are bored and don't know what to do) to starting fixing one of unit tests that we commented will be nice so we don't need to do it later.
But again, no urgency, no pressure, don't feel obligated :)