update library and replace deprecate method #116

ferndem · 2024-02-17T12:32:03Z

update snakyaml library

https://community.jenkins.io/t/getting-error-in-while-running-jenkins-job/9495/3

replace deprecated method

Testing done

Execute exists test (It is not possible to create reproducible tests it's necessary an installation of jenkins with SnakeYaml 2.2.)

Submitter checklist

Give feedback

Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
Ensure that the pull request title represents the desired changelog entry
Please describe what you did
Link to relevant issues in GitHub or Jira
Link to relevant pull requests, esp. upstream and downstream changes
Ensure you have provided tests - that demonstrates feature works or fixes the issue
Options

update library snakyml for plugin problem

maxlaverse · 2024-02-17T17:11:29Z

Hi @ferndem,
Thanks for contributing.

I triggered tests using the latest version of Jenkins, of this plugin, and of the SnakeAPIPlugin which came in version 2.2-111.vc6598e30cc65. I couldn't reproduce the problem mentioned in the thread. Are you sure this plugin was the cause ? And how do your changes fix that ?

ferndem · 2024-02-18T07:37:00Z

Hi @maxlaverse,
The problem on my jenkins occurred during the creation of the agent container. I had the problem after an automatic update. Jenkins provided me with a list of plugins that depended on SnakeYml and on the system they were: kubernetes-plugin, kubernetes-cli-plugin and kubernetes-credencials-plugin. Kuberntes-plugin already has SnakeYml 2.2 among its dependencies, the others do not.
My pull-request contains the update to the jakson2-api library which has SnakeYml as a dependency

maxlaverse · 2024-02-18T10:22:08Z

Thanks @ferndem. Can you give me instructions how to reproduce the issue ?

ferndem · 2024-02-20T15:21:50Z

@maxlaverse it's possible to reproduce with this step:

Install Jenkins v2.387.1 with plugin:
- kubernetes
- kubernetes-cli
- kuberntes-client-api
- kuberntes-credentials-plugin
Configure cloud setting (with kubernetes)
Execute pipeline:

podTemplate(yaml: """
apiVersion: v1
kind: Pod
spec:
 containers:
 - name: maven
   image: maven:3.6.3-jdk-11
   command:
   - cat
   tty: true
"""
) {
   node(POD_LABEL) {
     container('maven') {
       sh "hostname"
     }
   }
}

ferndem · 2024-02-20T15:33:03Z

@maxlaverse Checking the bug I noticed that the problem is related to kuberntes-plugin and not to kuberntes-cli-plugin (jenkins version 2.387.1 update it to version 3937.vd7b_82db_e347b_ and this is the problem). You can also delete the pull request if you consider the changes unnecessary and harmful

maxlaverse · 2024-02-20T16:27:30Z

Thanks for the feedback @ferndem.

The PR is probably not harmful but I don't get all the changes. If it takes to long for me to understand, I would probably close&re-open later. Thanks for the work no matter the outcome

maxlaverse · 2024-02-20T16:27:47Z

pom.xml

@@ -9,7 +9,6 @@

  <name>Kubernetes CLI Plugin</name>
  <url>https://github.com/jenkinsci/kubernetes-cli-plugin</url>
-  <groupId>org.jenkins-ci.plugins</groupId>


Why is the groupId not needed anymore ?

there was a warning because the group took it from the parent

maxlaverse · 2024-02-20T16:28:53Z

pom.xml

@@ -102,7 +99,6 @@
    <dependency>
      <groupId>org.jenkinsci.plugins</groupId>
      <artifactId>kubernetes-credentials</artifactId>
-      <version>${jenkins-kubernetes-credentials.version}</version>


Why did you decided to unpin all those dependencies ? Doesn't it mean that Jenkins will be less restrictive when deciding which plugins it can update / start with, and this would lead to runtime errors instead of update/boot errors ?

using managed version from group io.jenkins.tools.bom - bom-2.401.x

maxlaverse · 2024-02-20T16:30:00Z

src/test/java/org/jenkinsci/plugins/kubernetes/cli/KubectlBuildWrapperTest.java

        r.jenkins.setAuthorizationStrategy(as);

-        try (ACLContext unused = ACL.as(User.get("user-not-enough-permissions", true, null).impersonate())) {
+        try (ACLContext unused = ACL.as2(User.get("user-not-enough-permissions", true, null).impersonate2())) {


For myself: https://javadoc.jenkins-ci.org/hudson/security/ACL.html#impersonate2(org.springframework.security.core.Authentication)

maxlaverse · 2024-02-20T16:31:36Z

src/test/java/org/jenkinsci/plugins/kubernetes/cli/helpers/DummyCredentials.java

                SecretBytes.fromBytes(storeFile));
        return new CertificateCredentialsImpl(CredentialsScope.GLOBAL, credentialId, "sample", PASSPHRASE,
                keyStoreSource);
    }

    public static BaseStandardCredentials brokenCertificateCredential(String credentialId) {
        byte[] storeFile = TestResourceLoader.loadAsByteArray("kubernetes.pkcs12");
-        CertificateCredentialsImpl.KeyStoreSource keyStoreSource = new CertificateCredentialsImpl.UploadedKeyStoreSource(
+        CertificateCredentialsImpl.KeyStoreSource keyStoreSource = new CertificateCredentialsImpl.UploadedKeyStoreSource(null,


For myself: https://javadoc.jenkins.io/plugin/credentials/com/cloudbees/plugins/credentials/impl/CertificateCredentialsImpl.UploadedKeyStoreSource.html#%3Cinit%3E(org.apache.commons.fileupload.FileItem,com.cloudbees.plugins.credentials.SecretBytes)

maxlaverse · 2024-02-20T16:32:54Z

src/test/java/org/jenkinsci/plugins/kubernetes/cli/KubectlBuildWrapperTest.java

@@ -140,10 +142,10 @@ public void testListingCredentialsWithoutAncestorAndMissingPermissions() throws

        r.jenkins.setSecurityRealm(r.createDummySecurityRealm());
        ProjectMatrixAuthorizationStrategy as = new ProjectMatrixAuthorizationStrategy();
-        as.add(Jenkins.READ, "user-not-enough-permissions");
+        as.add(Jenkins.READ, new PermissionEntry(AuthorizationType.EITHER, "user-not-enough-permissions"));


For myself:

maxlaverse · 2024-02-21T12:54:11Z

Thanks @ferndem

ferndem and others added 2 commits February 17, 2024 10:40

update snakeyml

ad1faa3

update library snakyml for plugin problem

replace deprecate method

a24e3e5

maxlaverse reviewed Feb 20, 2024

View reviewed changes

maxlaverse self-requested a review February 20, 2024 16:33

maxlaverse merged commit e844f40 into jenkinsci:master Feb 21, 2024
4 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

update library and replace deprecate method #116

update library and replace deprecate method #116

ferndem commented Feb 17, 2024 •

edited

Loading

Submitter checklist

maxlaverse commented Feb 17, 2024

ferndem commented Feb 18, 2024

maxlaverse commented Feb 18, 2024

ferndem commented Feb 20, 2024

ferndem commented Feb 20, 2024

maxlaverse commented Feb 20, 2024

maxlaverse Feb 20, 2024

ferndem Feb 20, 2024

maxlaverse Feb 20, 2024

ferndem Feb 20, 2024

maxlaverse Feb 20, 2024

maxlaverse Feb 20, 2024

maxlaverse Feb 20, 2024

maxlaverse commented Feb 21, 2024

update library and replace deprecate method #116

update library and replace deprecate method #116

Conversation

ferndem commented Feb 17, 2024 • edited Loading

Testing done

Submitter checklist

maxlaverse commented Feb 17, 2024

ferndem commented Feb 18, 2024

maxlaverse commented Feb 18, 2024

ferndem commented Feb 20, 2024

ferndem commented Feb 20, 2024

maxlaverse commented Feb 20, 2024

maxlaverse Feb 20, 2024

Choose a reason for hiding this comment

ferndem Feb 20, 2024

Choose a reason for hiding this comment

maxlaverse Feb 20, 2024

Choose a reason for hiding this comment

ferndem Feb 20, 2024

Choose a reason for hiding this comment

maxlaverse Feb 20, 2024

Choose a reason for hiding this comment

maxlaverse Feb 20, 2024

Choose a reason for hiding this comment

maxlaverse Feb 20, 2024

Choose a reason for hiding this comment

maxlaverse commented Feb 21, 2024

ferndem commented Feb 17, 2024 •

edited

Loading