Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in documentation #163

Merged
merged 2 commits into from
Mar 23, 2024
Merged

Conversation

tnasim-intel
Copy link
Contributor

The parameter authenticate does not work anymore. Updated with authentication.
Same for httpProxy-authenticate --> proxyAuthentication

Testing done

Just documentation updated, so, didn't run any builds to test.

Submitter checklist

@tnasim-intel tnasim-intel requested a review from a team as a code owner January 24, 2024 00:20
Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

I was able to generate matching syntax from the Pipeline Syntax Generator for each of the cases that mentioned authentication. I was able to generate proxyAuthentication: 'credential-id' from the the Pipeline snippet syntax generator. I was not able to generate proxyAuthentication: Basic from the Pipeline snippet syntax generator.

This is certainly an improvement and I'm happy to merge it. Can you offer any additional pointers so that I can duplicate the proxyAuthentication: Basic syntax interactively from the Pipeline snippet syntax generator?

@MarkEWaite MarkEWaite merged commit c995313 into jenkinsci:master Mar 23, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants