Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more tests #84

Merged
merged 3 commits into from
Sep 21, 2024
Merged

Conversation

MarkEWaite
Copy link
Contributor

Test addShortText 5 argument method

No assertions that the values have the expected results, just calls to assure that the job does not fail when the call is invoked.

Testing done

Confirmed that tests pass as expected.

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

No assertions that the values have the expected results, just calls to
assure that the job does not fail when the call is invoked.
@MarkEWaite MarkEWaite requested a review from a team as a code owner September 21, 2024 19:50
@MarkEWaite MarkEWaite added the test Automated test addition or improvement label Sep 21, 2024
Inadequate assertions but at least the methods are called
@MarkEWaite MarkEWaite changed the title Test addShortText 5 argument method Add more tests Sep 21, 2024
@MarkEWaite MarkEWaite merged commit 15976b2 into jenkinsci:master Sep 21, 2024
16 checks passed
@MarkEWaite MarkEWaite deleted the test-addShortText-better branch September 21, 2024 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Automated test addition or improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant