Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Includes changes from all other PRs #17

Open
wants to merge 18 commits into
base: master
Choose a base branch
from
Open

Includes changes from all other PRs #17

wants to merge 18 commits into from

Conversation

presPetkov
Copy link

This includes changes from:

#10
#13
#14
#16

And a change based on a comment in the PR.

It looks like nobody is looking after this project. Creating the PR in order to get a build I can run a few tests against which contains all PR fixes.

jamestelfer and others added 13 commits November 27, 2016 12:47
@jamestelfer
Fix spelling/grammar in UI resources
c8fc8d2 
Correct tense, plurals and spelling. "Not build" should either be "No build" or "Not built". The second is the most likely given the apparent context.
Load/Save methods should be synchronized
b4f5a6b
Load must happen before save when starting
aefec7f
Warning and ignoring problematic jobresult file
7cbc66f
files are renamed with .error-stamp and ignored when run second time
df45d0a
@rafal-prasal
remove DUPA debugging
488de28
@rafal-prasal
JENKINS-43183 Can't see pipeline jobs in Global Build Stats
6463dbe
better name for pipeline job
f760664
Merge branch 'patch-1' of https://github.com/jamestelfer/global-build…
f75440f 
…-stats-plugin into AllPRs
Merge branch 'master' of https://github.com/rafal-prasal/global-build…
2dde2f3 
…-stats-plugin into AllPRs
Merge branch 'JENKINS-43183' of https://github.com/rafal-prasal/globa…
6c0ab3e 
…l-build-stats-plugin into AllPRs
Change discovery to recursive as per jenkinsci#14 (comment)
4752e41
Updated dependencies
42042b4
@presPetkov
Copy link
Author

Test build - https://ci.jenkins.io/job/Plugins/job/global-build-stats-plugin/job/PR-17/1/artifact/target/global-build-stats.hpi

@presPetkov
Copy link
Author

Latest test build - https://ci.jenkins.io/job/Plugins/job/global-build-stats-plugin/job/PR-17/2/artifact/target/global-build-stats.hpi

@gounthar
Copy link
Contributor

gounthar commented Jan 4, 2023

[ERROR] COMPILATION ERROR : [2023-01-04T13:02:30.602Z] [INFO] ------------------------------------------------------------- [2023-01-04T13:02:30.602Z] [ERROR] C:\Jenkins\workspace\_global-build-stats-plugin_PR-17\src\main\java\hudson\plugins\global_build_stats\GlobalBuildStatsPlugin.java:[20,41] error: package org.jenkinsci.plugins.workflow.job does not exist [2023-01-04T13:02:30.602Z] [ERROR] C:\Jenkins\workspace\_global-build-stats-plugin_PR-17\src\main\java\hudson\plugins\global_build_stats\business\GlobalBuildStatsBusiness.java:[36,49] error: package org.jenkinsci.plugins.workflow.multibranch does not exist [2023-01-04T13:02:30.602Z] [ERROR] C:\Jenkins\workspace\_global-build-stats-plugin_PR-17\src\main\java\hudson\plugins\global_build_stats\GlobalBuildStatsPlugin.java:[266,80] error: cannot find symbol [2023-01-04T13:02:30.602Z] symbol: class WorkflowRun [2023-01-04T13:02:30.602Z] location: class GlobalBuildStatsPlugin [2023-01-04T13:02:30.602Z] [ERROR] C:\Jenkins\workspace\_global-build-stats-plugin_PR-17\src\main\java\hudson\plugins\global_build_stats\GlobalBuildStatsPlugin.java:[272,32] error: cannot find symbol [2023-01-04T13:02:30.602Z] symbol: class WorkflowRun [2023-01-04T13:02:30.602Z] location: class GlobalBuildStatsWorkflowRunListener [2023-01-04T13:02:30.602Z] [ERROR] C:\Jenkins\workspace\_global-build-stats-plugin_PR-17\src\main\java\hudson\plugins\global_build_stats\GlobalBuildStatsPlugin.java:[279,30] error: cannot find symbol [2023-01-04T13:02:30.602Z] symbol: class WorkflowRun [2023-01-04T13:02:30.602Z] location: class GlobalBuildStatsWorkflowRunListener [2023-01-04T13:02:30.602Z] [ERROR] C:\Jenkins\workspace\_global-build-stats-plugin_PR-17\src\main\java\hudson\plugins\global_build_stats\JobBuildResultFactory.java:[8,41] error: package org.jenkinsci.plugins.workflow.job does not exist [2023-01-04T13:02:30.602Z] [INFO] 6 errors

@MarkEWaite
Copy link
Contributor

[ERROR] COMPILATION ERROR : [2023-01-04T13:02:30.602Z] [INFO] ------------------------------------------------------------- [2023-01-04T13:02:30.602Z] [ERROR] C:\Jenkins\workspace\_global-build-stats-plugin_PR-17\src\main\java\hudson\plugins\global_build_stats\GlobalBuildStatsPlugin.java:[20,41] error: package org.jenkinsci.plugins.workflow.job does not exist [2023-01-04T13:02:30.602Z] [ERROR] C:\Jenkins\workspace\_global-build-stats-plugin_PR-17\src\main\java\hudson\plugins\global_build_stats\business\GlobalBuildStatsBusiness.java:[36,49] error: package org.jenkinsci.plugins.workflow.multibranch does not exist [2023-01-04T13:02:30.602Z] [ERROR] C:\Jenkins\workspace\_global-build-stats-plugin_PR-17\src\main\java\hudson\plugins\global_build_stats\GlobalBuildStatsPlugin.java:[266,80] error: cannot find symbol [2023-01-04T13:02:30.602Z] symbol: class WorkflowRun [2023-01-04T13:02:30.602Z] location: class GlobalBuildStatsPlugin [2023-01-04T13:02:30.602Z] [ERROR] C:\Jenkins\workspace\_global-build-stats-plugin_PR-17\src\main\java\hudson\plugins\global_build_stats\GlobalBuildStatsPlugin.java:[272,32] error: cannot find symbol [2023-01-04T13:02:30.602Z] symbol: class WorkflowRun [2023-01-04T13:02:30.602Z] location: class GlobalBuildStatsWorkflowRunListener [2023-01-04T13:02:30.602Z] [ERROR] C:\Jenkins\workspace\_global-build-stats-plugin_PR-17\src\main\java\hudson\plugins\global_build_stats\GlobalBuildStatsPlugin.java:[279,30] error: cannot find symbol [2023-01-04T13:02:30.602Z] symbol: class WorkflowRun [2023-01-04T13:02:30.602Z] location: class GlobalBuildStatsWorkflowRunListener [2023-01-04T13:02:30.602Z] [ERROR] C:\Jenkins\workspace\_global-build-stats-plugin_PR-17\src\main\java\hudson\plugins\global_build_stats\JobBuildResultFactory.java:[8,41] error: package org.jenkinsci.plugins.workflow.job does not exist [2023-01-04T13:02:30.602Z] [INFO] 6 errors

Apologies! I used the GitHub merge facility to resolve conflicts and appear to have made a merge mistake. Will correct it.

@gounthar
Copy link
Contributor

gounthar commented Jan 4, 2023

I was not putting blame on anybody, just trying to locate the error in the build so that anybody wanting to have a look has a first track to follow. 😊

Thank you so much.

@MarkEWaite
Copy link
Contributor

I probably should have just left the pull request alone, since I don't have enough time to review it. However, it seemed like an easy conflict to resolve. Surprise, there was more to the fix than just resolving the conflict. However, hopefully that might allow others to test the pull request as @presPetkov did several years ago.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@presPetkov @gounthar @MarkEWaite @jamestelfer @rafal-prasal