Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-73791] Prevent PR 404 on details to break Branches scan #811

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Dohbedoh
Copy link
Contributor

@Dohbedoh Dohbedoh commented Sep 19, 2024

Description

JENKINS-73791: The retrieval of branches can fail the entire Branch Scanning if a BranchDiscoveryTrait strategy that involves checking on PRs is used while some PR parts cannot be retrieved with a 404 FileNotFoundException.

This is an extension of JENKINS-56996 / #224.

Submitter checklist

  • Link to JIRA ticket in description, if appropriate.
  • Change is code complete and matches issue description
  • Automated tests have been added to exercise the changes
  • Reviewer's manual test instructions provided in PR description. See Reviewer's first task below.

Reviewer checklist

  • Run the changes and verify that the change matches the issue description
  • Reviewed the code
  • Verified that the appropriate tests have been written or valid explanation given

Documentation changes

  • Link to jenkins.io PR, or an explanation for why no doc changes are needed

Users/aliases to notify

@jenkinsci/github-branch-source-plugin-developers

@Dohbedoh Dohbedoh requested a review from a team as a code owner September 19, 2024 05:56
@Dohbedoh
Copy link
Contributor Author

First commit to reproduce the failure.
Second commit coming soon to demonstrate the fix.

@Dohbedoh
Copy link
Contributor Author

@dwnusbaum @jeromepochat @rsandell Can we merge this ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant