Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated for compatibility with Jenkins 2.0 workflow API #6

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

cjbush
Copy link

@cjbush cjbush commented Apr 26, 2016

No description provided.

nbactions.xml Outdated
@@ -0,0 +1,12 @@
<?xml version="1.0" encoding="UTF-8"?>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Depends on the project, of course, but typically IDE related files are undesired.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right, I'll remove that. My bad.

@Aeon512
Copy link

Aeon512 commented May 16, 2016

@cjbush Can you tell me how to overcome those 15 test execution errors? I tried to compile locally, but ended up with the same test errors as on the cloudbees Jenkins.

@cjbush
Copy link
Author

cjbush commented May 16, 2016

@Aeon512 I'm working on trying to get the unit tests to pass locally. I'm not sure what's causing the failure, but I'm guessing it's some kind of breaking change in one of the APIs. If you want to play around with the patch without the unit tests passing, you can just build it with the skip unit tests flag set in Maven.

@Aeon512
Copy link

Aeon512 commented May 16, 2016

afaik the parent jenkins plugin should be increased to something like 1.609.1, that is

  <parent>
    <groupId>org.jenkins-ci.plugins</groupId>
    <artifactId>plugin</artifactId>
    <version>1.609.1</version>
    <relativePath />
  </parent> 

With this change, the three additional dependencies are no longer necessary to compile.

There are still 8 test errors in EmmaConfigSubmitTest due to a changed HTML Layout of the new Jenkins page. E.g. there is not longer an input with name hudson-plugins-emma-EmmaPublisher. There are some inputs with an id hudson.plugins.emma.EmmaPublisher though, but it seems like there has to be changed a bit more. However, this looks a more promising approach to me.

@Aeon512
Copy link

Aeon512 commented May 17, 2016

@cjbush I've just sent you a pull request for your repository fixing the unit tests. Would be great if you could include this fix in this pull request to get the emma plugin updated, so we can finally approach the pipeline support for the mstest plugin :)

@Aeon512
Copy link

Aeon512 commented May 18, 2016

@cjbush Thanks for merging. Honestly, I have no idea why this build got stuck :-/
Below is the output from my local tests. As you can see the tests within EmmaConfigSubmitTest take quite some time... but that should be well below the 30 minutes limit before the build gets aborted.

-------------------------------------------------------
 T E S T S
-------------------------------------------------------
Running hudson.plugins.emma.CoverageObjectTest
Running hudson.plugins.emma.CoverageReportTest
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.24 sec - in hudson.plugins.emma.CoverageObjectTest
Running hudson.plugins.emma.EmmaBuildActionTest
Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.271 sec - in hudson.plugins.emma.EmmaBuildActionTest
Running hudson.plugins.emma.EmmaConfigSubmitTest
Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.033 sec - in hudson.plugins.emma.CoverageReportTest
Running hudson.plugins.emma.EmmaPublisherTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.614 sec - in hudson.plugins.emma.EmmaPublisherTest
Running hudson.plugins.emma.portlet.EmmaLoadDataHudsonTest
Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 32.857 sec - in hudson.plugins.emma.portlet.EmmaLoadDataHudsonTest
Running hudson.plugins.emma.portlet.utils.UtilsHudsonTest
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 4.395 sec - in hudson.plugins.emma.portlet.utils.UtilsHudsonTest
Running hudson.plugins.emma.portlet.utils.UtilsParameterizedTest
Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.037 sec - in hudson.plugins.emma.portlet.utils.UtilsParameterizedTest
Running hudson.plugins.emma.RatioTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.001 sec - in hudson.plugins.emma.RatioTest
Running InjectedTest
Tests run: 21, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 5.1 sec - in InjectedTest
Tests run: 8, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 112.628 sec - in hudson.plugins.emma.EmmaConfigSubmitTest

Results :

Tests run: 54, Failures: 0, Errors: 0, Skipped: 0

@Aeon512
Copy link

Aeon512 commented May 21, 2016

@cjbush Do the tests get stall for you as well?
@daniel-beck Actually the tests passed locally - do you have an idea what the issue could be?

@phillipjohnson
Copy link

Are there any updates on this? There's a plugin downstream that can benefit from this PR. jenkinsci/mstest-plugin#10

@daniel-beck
Copy link
Member

@Aeon512 The PR build is aborted, I think because it took 30 minutes and got timeouted. I wouldn't worry too much about that result. Note that jenkins.ci.cloudbees.com is considered legacy infra, modern PR builds with Pipeline Jenkinsfiles are run on ci.jenkins.io now.

@Aeon512
Copy link

Aeon512 commented Apr 24, 2017

@daniel-beck Then I would second @phillipjohnson request to merge this PR

@daniel-beck
Copy link
Member

@Aeon512 I don't maintain or even use this component, I'm just co-owner of the GitHub org, so I'm not informed enough to merge and release this with any confidence.

@Aeon512
Copy link

Aeon512 commented Jun 26, 2017

@daniel-beck So we are stuck here?
Without a new emma release, the PR for the MSTest Plugin to integrate Pipeline support is also stuck which will be the end of using MSTest in Jenkins with Pipeline and will force everybody to make their own private builds?

@daniel-beck
Copy link
Member

@Aeon512 The last notable changes to this plugin were performed by @manolo who stopped contributing to Jenkins years ago.

See https://jenkins.io/project/governance/#helping-and-taking-over-dormant-plugins and https://wiki.jenkins-ci.org/display/JENKINS/Adopt+a+Plugin for more information if you want to step up.

@Aeon512
Copy link

Aeon512 commented Jun 26, 2017

@daniel-beck I see, but unfortunately I don't really have the time nor the java knowledge to step up on this. Was looking into this issue more from a management perspective to get something up and running finally...

@phillipjohnson @cjbush Any one of you might consider stepping up?

@cjbush
Copy link
Author

cjbush commented Jun 26, 2017

Hey @Aeon512, I'll take a look at it in a week if that's alright. I'm leaving for my honeymoon in a couple of hours.

@cjbush
Copy link
Author

cjbush commented Jun 26, 2017

(And sorry it's taken so long to get back, I've been a bit preoccupied, getting married and all 😄 )

@Aeon512
Copy link

Aeon512 commented Jun 26, 2017

@cjbush Thanks a lot for that. And happy honeymoon :-) enjoy the time offline

@Aeon512
Copy link

Aeon512 commented Oct 9, 2017

@cjbush Any updates?

@phillipjohnson
Copy link

@Aeon512 You might be interested in this release: https://github.com/jenkinsci/mstest-plugin/releases/tag/mstest-0.20. I have not had a chance to try it out yet, but it looks like they were able to make the plugin pipeline-compatible without this PR.

@Aeon512
Copy link

Aeon512 commented Oct 9, 2017

@phillipjohnson Thanks for that hint. Looks promising.

@cjbush
Copy link
Author

cjbush commented May 2, 2018

OK, I'm back. Sorry for the extended delay. It looks like the MSTest plugin has stopped calling the Emma publisher when you pass enableCodeCoverageAnalysis: true to the pipeline step, so I'll experiment with creating an explicit step for the Emma publisher. The Jacoco plugin is pretty useless since it only supports their binary .exec format, which the MSTest plugin doesn't generate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants