-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated for compatibility with Jenkins 2.0 workflow API #6
base: master
Are you sure you want to change the base?
Conversation
nbactions.xml
Outdated
@@ -0,0 +1,12 @@ | |||
<?xml version="1.0" encoding="UTF-8"?> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Depends on the project, of course, but typically IDE related files are undesired.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right, I'll remove that. My bad.
@cjbush Can you tell me how to overcome those 15 test execution errors? I tried to compile locally, but ended up with the same test errors as on the cloudbees Jenkins. |
@Aeon512 I'm working on trying to get the unit tests to pass locally. I'm not sure what's causing the failure, but I'm guessing it's some kind of breaking change in one of the APIs. If you want to play around with the patch without the unit tests passing, you can just build it with the skip unit tests flag set in Maven. |
afaik the parent jenkins plugin should be increased to something like
With this change, the three additional dependencies are no longer necessary to compile. There are still 8 test errors in EmmaConfigSubmitTest due to a changed HTML Layout of the new Jenkins page. E.g. there is not longer an input with name |
@cjbush I've just sent you a pull request for your repository fixing the unit tests. Would be great if you could include this fix in this pull request to get the emma plugin updated, so we can finally approach the pipeline support for the mstest plugin :) |
Fixed UnitTests
@cjbush Thanks for merging. Honestly, I have no idea why this build got stuck :-/
|
@cjbush Do the tests get stall for you as well? |
Are there any updates on this? There's a plugin downstream that can benefit from this PR. jenkinsci/mstest-plugin#10 |
@Aeon512 The PR build is aborted, I think because it took 30 minutes and got timeouted. I wouldn't worry too much about that result. Note that jenkins.ci.cloudbees.com is considered legacy infra, modern PR builds with Pipeline Jenkinsfiles are run on ci.jenkins.io now. |
@daniel-beck Then I would second @phillipjohnson request to merge this PR |
@Aeon512 I don't maintain or even use this component, I'm just co-owner of the GitHub org, so I'm not informed enough to merge and release this with any confidence. |
@daniel-beck So we are stuck here? |
@Aeon512 The last notable changes to this plugin were performed by @manolo who stopped contributing to Jenkins years ago. See https://jenkins.io/project/governance/#helping-and-taking-over-dormant-plugins and https://wiki.jenkins-ci.org/display/JENKINS/Adopt+a+Plugin for more information if you want to step up. |
@daniel-beck I see, but unfortunately I don't really have the time nor the java knowledge to step up on this. Was looking into this issue more from a management perspective to get something up and running finally... @phillipjohnson @cjbush Any one of you might consider stepping up? |
Hey @Aeon512, I'll take a look at it in a week if that's alright. I'm leaving for my honeymoon in a couple of hours. |
(And sorry it's taken so long to get back, I've been a bit preoccupied, getting married and all 😄 ) |
@cjbush Thanks a lot for that. And happy honeymoon :-) enjoy the time offline |
@cjbush Any updates? |
@Aeon512 You might be interested in this release: https://github.com/jenkinsci/mstest-plugin/releases/tag/mstest-0.20. I have not had a chance to try it out yet, but it looks like they were able to make the plugin pipeline-compatible without this PR. |
@phillipjohnson Thanks for that hint. Looks promising. |
OK, I'm back. Sorry for the extended delay. It looks like the MSTest plugin has stopped calling the Emma publisher when you pass enableCodeCoverageAnalysis: true to the pipeline step, so I'll experiment with creating an explicit step for the Emma publisher. The Jacoco plugin is pretty useless since it only supports their binary .exec format, which the MSTest plugin doesn't generate. |
No description provided.