Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update jmh-benchmarks.md #2617

Closed
wants to merge 1 commit into from
Closed

Update jmh-benchmarks.md #2617

wants to merge 1 commit into from

Conversation

AKSHITRAYAL
Copy link

@AKSHITRAYAL AKSHITRAYAL commented Jan 1, 2025 •
edited
Loading

No exceptions!!
Code needed a bit of commenting

Your checklist for this pull request

🚨 Please review the guidelines for contributing to this repository.

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side) and not your master branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or in Jenkins JIRA
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Did you provide a test-case? That demonstrates feature works or fixes the issue.

@AKSHITRAYAL
Update jmh-benchmarks.md
4ae2eda 
No exceptions!!
Code needed a bit of commenting
@AKSHITRAYAL AKSHITRAYAL requested a review from a team as a code owner January 1, 2025 10:10
timja
timja requested changes Jan 1, 2025
View reviewed changes
Copy link
Member

@timja timja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not useful

@timja timja closed this Jan 1, 2025
@AKSHITRAYAL
Copy link
Author

This is not useful

@timja I would like to know what was the issue with the code, as I did not find anynthing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timja timja timja requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AKSHITRAYAL @timja