Report with results of both SCA and SAST from Jenkins Plugin #117
+145
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swatiawate1
requested review from
SubhadraSahoo,
umeshwaghode and
PravinGadankush
| @@ -1242,10 +1287,19 @@ private void mapSastConfiguration(Optional<SastConfig> sast, CxScanConfig scanCo | |||
| } | |||
|
|
|||
|
|
|||
| private void createScaReports(AstScaResults scaResults, File checkmarxBuildDir) { | |||
| private void createScaReports(AstScaResults scaResults, File checkmarxBuildDir, @Nonnull FilePath workspace) { | |||
There was a problem hiding this comment.
i dont see use of new argument workspace in this method. Kindly check if it is required.
| @@ -1498,6 +1552,20 @@ private CxScanConfig resolveConfiguration(Run<?, ?> run, DescriptorImpl descript | |||
| } | |||
| ret.setEnablePolicyViolations(enableProjectPolicyEnforcement); | |||
|
|
|||
| if (!ret.isAstScaEnabled() && !ret.getSynchronous()) { | |||
There was a problem hiding this comment.
Please check if the condition should be && or ||
| @@ -1004,7 +1045,7 @@ public void perform(@Nonnull Run<?, ?> run, @Nonnull FilePath workspace, @Nonnul | |||
| if (osaResults != null && osaResults.isOsaResultsReady()) { | |||
| createOsaReports(osaResults, checkmarxBuildDir); | |||
| } else if (scaResults != null && scaResults.isScaResultReady()) { | |||
| createScaReports(scaResults, checkmarxBuildDir); | |||
| createScaReports(scaResults, checkmarxBuildDir, workspace); | |||
There was a problem hiding this comment.
Check if additional argument workspace is needed in this method.
PravinGadankush
approved these changes
May 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.