-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pin previous credentials-binding release for LTS profiles #2514
Merged
MarkEWaite
merged 1 commit into
jenkinsci:master
from
MarkEWaite:adapt-to-config-file-provider-test-failure-from-credentials-binding
Sep 17, 2023
Merged
Pin previous credentials-binding release for LTS profiles #2514
MarkEWaite
merged 1 commit into
jenkinsci:master
from
MarkEWaite:adapt-to-config-file-provider-test-failure-from-credentials-binding
Sep 17, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The most recent release of the credentials-binding plugin adds masking for base64 credentials. That's a nice improvement. Unfortunately, it causes one of the config-file-provider tests to fail. Adapt older bom profiles to "Bump credentials-binding (jenkinsci#2509)" by retaining the current version of the credentials binding plugin on the weekly release and pinning the previous credentials binding plugin release on the LTS releases. Could exclude the test failure on all releases, but it seemed better to be able to detect test failures from the weekly release even if we can't yet test the new version with the LTS releases. This partially reverts commit bab8257.
MarkEWaite
added
the
full-test
Test all LTS lines in this PR and do not halt upon first error.
label
Sep 16, 2023
This was referenced Sep 16, 2023
With 560+ passing tests and progress not being updated in several minutes, I'm taking the preemptive step to merge this so that the next stage in release preparation can continue. Once that is completed successfully, then a full build of the master branch will be run so that it can be released. Probably 12-15 hours more before the release will be complete. |
MarkEWaite
deleted the
adapt-to-config-file-provider-test-failure-from-credentials-binding
branch
September 17, 2023 03:29
MarkEWaite
added a commit
that referenced
this pull request
Sep 17, 2023
MarkEWaite
added a commit
that referenced
this pull request
Sep 18, 2023
)" The config-file-provider plugin 959.vcff671a_4518b_ release resolves the test failure on LTS lines. jenkinsci/config-file-provider-plugin#296 is the pull request to config-file-provider that resolved the issue. https://github.com/jenkinsci/config-file-provider-plugin/releases/tag/959.vcff671a_4518b_ is the changelog for the config-file-provider release. This reverts commit c111cf5.
github-actions bot
pushed a commit
that referenced
this pull request
Sep 18, 2023
…4d2 to 959.vcff671a_4518b_ in /bom-weekly (#2517) * Bump org.jenkins-ci.plugins:config-file-provider in /bom-weekly Bumps [org.jenkins-ci.plugins:config-file-provider](https://github.com/jenkinsci/config-file-provider-plugin) from 953.v0432a_802e4d2 to 959.vcff671a_4518b_. - [Release notes](https://github.com/jenkinsci/config-file-provider-plugin/releases) - [Commits](https://github.com/jenkinsci/config-file-provider-plugin/commits) --- updated-dependencies: - dependency-name: org.jenkins-ci.plugins:config-file-provider dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> * Revert "Pin previous credentials-binding release for LTS profiles (#2514)" The config-file-provider plugin 959.vcff671a_4518b_ release resolves the test failure on LTS lines. jenkinsci/config-file-provider-plugin#296 is the pull request to config-file-provider that resolved the issue. https://github.com/jenkinsci/config-file-provider-plugin/releases/tag/959.vcff671a_4518b_ is the changelog for the config-file-provider release. This reverts commit c111cf5. --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Mark Waite <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pin previous credentials-binding release for LTS profiles
The most recent release of the credentials-binding plugin adds masking for base64 credentials. That's a nice improvement. Unfortunately, it causes one of the config-file-provider tests to fail.
Adapt older bom profiles to "Bump credentials-binding (#2509)" by retaining the current version of the credentials binding plugin on the weekly release and pinning the previous credentials binding plugin release on the LTS releases.
Could exclude the test failure on all releases, but it seemed better to be able to detect test failures from the weekly release even if we can't yet test the new version with the LTS releases.
This partially reverts commit bab8257.
Testing done
Confirmed that the failing config-file-provider tests now pass. Used the build.sh script like this to bisect with
git bisect run
:Submitter checklist