Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use merge commit for build if event is pull request fulfilled #346

Merged

Conversation

julioc-p
Copy link
Collaborator

@julioc-p julioc-p commented Oct 8, 2024

Pass merge commit to the git plugin instead of the source commit when a Pull request is merged, thus correcting the behaviour of the pull request merge trigger and avoiding double builds in case of a push event and a pull request merged event at the same time fixing #201

Testing done

Test that the latest commit does in deed uses the merge commit from the payload in case of a pull request merge

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@julioc-p julioc-p linked an issue Oct 8, 2024 that may be closed by this pull request
@github-actions github-actions bot added the test label Oct 8, 2024
@julioc-p julioc-p requested a review from cdelmonte-zg October 8, 2024 14:51
@julioc-p julioc-p merged commit 1eb4046 into master Oct 14, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PR Merge and Push causes double-build of branch
1 participant