Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New field for status propagation of pipeline #338

Merged
merged 14 commits into from
Sep 12, 2024
Merged

New field for status propagation of pipeline #338

merged 14 commits into from
Sep 12, 2024

Conversation

julioc-p
Copy link
Collaborator

New field to specify status propagation url

Testing done

Added tests to check if the baseUrl is set from this new propagation url if it is set

@julioc-p julioc-p linked an issue Aug 29, 2024 that may be closed by this pull request
Build Status not propagating to Bitbucket On Prem #331
Closed
@julioc-p julioc-p requested a review from cdelmonte-zg August 29, 2024 12:32
github-advanced-security[bot]
github-advanced-security bot found potential problems Sep 5, 2024
View reviewed changes
src/main/java/io/jenkins/plugins/bitbucketpushandpullrequest/BitBucketPPRTrigger.java
@@ -287,23 +351,31 @@
private final SequentialExecutionQueue queue =
new SequentialExecutionQueue(Jenkins.MasterComputer.threadPoolForRemoting);

public ListBoxModel doFillCredentialsIdItems(@AncestorInPath Item context,
@QueryParameter String remote, @QueryParameter String credentialsId) {
public ListBoxModel doFillCredentialsIdItems(

Check warning

Code scanning / Jenkins Security Scan

Stapler: Missing POST/RequirePOST annotation Warning

Potential CSRF vulnerability: If DescriptorImpl#doFillCredentialsIdItems connects to user-specified URLs, modifies state, or is expensive to run, it should be annotated with @POST or @RequirePOST
...ain/java/io/jenkins/plugins/bitbucketpushandpullrequest/config/BitBucketPPRPluginConfig.java
@@ -121,18 +140,24 @@
return true;
}

public ListBoxModel doFillCredentialsIdItems(@AncestorInPath Item context,
@QueryParameter String remote, @QueryParameter String credentialsId) {
public ListBoxModel doFillCredentialsIdItems(

Check warning

Code scanning / Jenkins Security Scan

Stapler: Missing POST/RequirePOST annotation Warning

Potential CSRF vulnerability: If BitBucketPPRPluginConfig#doFillCredentialsIdItems connects to user-specified URLs, modifies state, or is expensive to run, it should be annotated with @POST or @RequirePOST
github-advanced-security[bot]
github-advanced-security bot found potential problems Sep 5, 2024
View reviewed changes
...ain/java/io/jenkins/plugins/bitbucketpushandpullrequest/config/BitBucketPPRPluginConfig.java
save();
}

public FormValidation doCheckPropagationUrl(@QueryParameter String value) {

Check warning

Code scanning / Jenkins Security Scan

Stapler: Missing permission check Warning

Potential missing permission check in BitBucketPPRPluginConfig#doCheckPropagationUrl
...ain/java/io/jenkins/plugins/bitbucketpushandpullrequest/config/BitBucketPPRPluginConfig.java
save();
}

public FormValidation doCheckPropagationUrl(@QueryParameter String value) {

Check warning

Code scanning / Jenkins Security Scan

Stapler: Missing POST/RequirePOST annotation Warning

Potential CSRF vulnerability: If BitBucketPPRPluginConfig#doCheckPropagationUrl connects to user-specified URLs, modifies state, or is expensive to run, it should be annotated with @POST or @RequirePOST
@cdelmonte-zg cdelmonte-zg merged commit 733e403 into master Sep 12, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdelmonte-zg cdelmonte-zg cdelmonte-zg approved these changes

Assignees
No one assigned
Labels
test views
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Build Status not propagating to Bitbucket On Prem
2 participants
@julioc-p @cdelmonte-zg