Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-73363] Add support for protoLint JSON format #1075

Merged

Conversation

profhenry
Copy link
Contributor

Pull request for https://issues.jenkins.io/browse/JENKINS-73363

Plaintext format is still supported. Unit test was added.

Copy link

codecov bot commented Jul 5, 2024

Codecov Report

Attention: Patch coverage is 80.76923% with 5 lines in your changes missing coverage. Please review.

Project coverage is 90.74%. Comparing base (3c14e8e) to head (83b78c5).
Report is 10 commits behind head on main.

Files Patch % Lines
.../hafner/analysis/registry/ProtoLintDescriptor.java 16.66% 5 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1075      +/-   ##
============================================
- Coverage     90.79%   90.74%   -0.05%     
- Complexity     2315     2322       +7     
============================================
  Files           354      355       +1     
  Lines          6526     6551      +25     
  Branches        674      675       +1     
============================================
+ Hits           5925     5945      +20     
- Misses          405      410       +5     
  Partials        196      196              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@uhafner uhafner added the feature New features label Jul 7, 2024
Copy link
Member

@uhafner uhafner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your pull request!

Just some minor comments or suggestions.

@uhafner uhafner changed the title Add support for protoLint JSON format [JENKINS-73363] Add support for protoLint JSON format Jul 15, 2024
@profhenry profhenry force-pushed the JENKINS-73363_ProtoLint_Parser_Enhancements branch from 882017f to 83b78c5 Compare July 15, 2024 19:03
@profhenry profhenry requested a review from uhafner July 15, 2024 19:23
Copy link
Member

@uhafner uhafner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@uhafner uhafner merged commit 1f99037 into jenkinsci:main Jul 16, 2024
26 of 28 checks passed
@profhenry profhenry deleted the JENKINS-73363_ProtoLint_Parser_Enhancements branch July 18, 2024 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants