Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the PMD square image. #1050

Merged
merged 1 commit into from
Apr 15, 2024
Merged

Use the PMD square image. #1050

merged 1 commit into from
Apr 15, 2024

Conversation

uhafner
Copy link
Member

@uhafner uhafner commented Apr 15, 2024

Use the square logo of PMD that provides a better scaling result. This icon still provides a poor rendering for actions (20x20) but it is better than the old one.

Before:

PMD   PMD: No warnings found

After:

PMD   PMD: 1 warning found (0 error, 0 high, 1 normal, 0 low)

@uhafner uhafner added the documentation Enhancement of documentation label Apr 15, 2024
Copy link

☀️   Quality Monitor

   🚦   Tests: 100 % successful (✔️ 1273 passed, 🙈 2 skipped)
   〰️   Line Coverage: 93% (473 missed lines)
   ➰   Branch Coverage: 88% (254 missed branches)
   CheckStyle   CheckStyle: No warnings found
   PMD   PMD: No warnings found
   SpotBugs   SpotBugs: 6 warnings found (0 error, 0 high, 0 normal, 6 low)

Created by Quality Monitor v1.7.0 (#823c682). More details are shown in the GitHub Checks Result.

Copy link

codecov bot commented Apr 15, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 89.74%. Comparing base (f96980f) to head (73a2765).
Report is 26 commits behind head on main.

Files Patch % Lines
...edu/hm/hafner/analysis/registry/PmdDescriptor.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##               main    #1050   +/-   ##
=========================================
  Coverage     89.74%   89.74%           
  Complexity     2242     2242           
=========================================
  Files           352      352           
  Lines          6522     6522           
  Branches        675      675           
=========================================
  Hits           5853     5853           
  Misses          473      473           
  Partials        196      196           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@uhafner uhafner merged commit 97722ee into main Apr 15, 2024
30 of 31 checks passed
@uhafner uhafner deleted the pmd-square-logo branch April 15, 2024 12:10
@adangel adangel mentioned this pull request Apr 19, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Enhancement of documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant