Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: cli completion #8725

Merged
merged 1 commit into from
Nov 11, 2024
Merged

feat: cli completion #8725

merged 1 commit into from
Nov 11, 2024

Conversation

msvticket
Copy link
Member

@msvticket msvticket commented Nov 8, 2024 •
edited
Loading

Fixes #8723

@jenkins-x-bot
Copy link
Contributor

[jx-info] Hi, we've detected that the pipelines in this repository are using a syntax that will soon be deprecated.
We'll continue to update you through PRs as we progress. Please check #8589 for further information.

@msvticket msvticket force-pushed the completion branch 3 times, most recently from 42e585d to 6985ae4 Compare November 9, 2024 13:40
@msvticket msvticket marked this pull request as ready for review November 9, 2024 13:41
@codecov Codecov
Copy link

codecov bot commented Nov 9, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 4.05405% with 213 lines in your changes missing coverage. Please review.

Project coverage is 31.62%. Comparing base (e9d6202) to head (e7399f7).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
pkg/plugins/helpers.go 0.00% 173 Missing ⚠️
pkg/cmd/root.go 25.00% 22 Missing and 2 partials ⚠️
pkg/cmd/namespace/namespace.go 5.88% 15 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #8725      +/-   ##
==========================================
- Coverage   34.94%   31.62%   -3.32%     
==========================================
  Files          11       11              
  Lines        1242     1369     +127     
==========================================
- Hits          434      433       -1     
- Misses        764      891     +127     
- Partials       44       45       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@msvticket
feat: cli completion
e7399f7 
completion for plugins (heavily inspired by kubectl)
namespace completion
some simplification
linting fixes

related to #8723

Signed-off-by: Mårten Svantesson <[email protected]>
@msvticket
Copy link
Member Author

/cc tomhobson JordanGoasdoue Skisocks mentlak0

@msvticket
Copy link
Member Author

/retest

@jenkins-x-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Skisocks

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jenkins-x-bot jenkins-x-bot merged commit 1dd6d85 into main Nov 11, 2024
8 of 11 checks passed
@jenkins-x-bot jenkins-x-bot deleted the completion branch November 11, 2024 11:22
@jenkins-x-bot
Copy link
Contributor

Failed to merge this PR due to:

failed merging [8725]: [Method Not Allowed]

@suzuki-shunsuke suzuki-shunsuke mentioned this pull request Nov 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Skisocks Skisocks Skisocks approved these changes

@JordanGoasdoue JordanGoasdoue Awaiting requested review from JordanGoasdoue

@mentlak0 mentlak0 Awaiting requested review from mentlak0

@tomhobson tomhobson Awaiting requested review from tomhobson

Assignees
No one assigned
Labels
approved size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement command line completion
3 participants
@msvticket @jenkins-x-bot @Skisocks