Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(cleanup AWS images) ensure staging images older than 7 days are removed #590

Merged

Conversation

dduportal
Copy link
Contributor

@dduportal dduportal commented Apr 11, 2023

Implements the "Delete staging images older than 1 week" from jenkins-infra/helpdesk#2846

This PR introduces 3 (linked) changes:

  • Parameterized the cleanup/aws_images.sh script to allow passing parameters
    • $1 specifies the number of days for which the AMIs older than this threshold will be removed. Defaults to 1 (day).
    • $2 specifies the build_type for AMIs to check for deletion. Defaults to dev.
  • Enable parallelization, like in chore(cleanup AWS snapshots) fixup of #587 #589 to ensure there are NO fail fast
  • Enable cleanup of staging images older than 7 days

@dduportal dduportal changed the title Chore/cleanup aws staging images chore(cleanup AWS images) ensure staging images older than 7 days are removed Apr 11, 2023
@dduportal dduportal marked this pull request as ready for review April 11, 2023 19:13
@dduportal
Copy link
Contributor Author

Merging, as the dry run looks good

@dduportal dduportal merged commit 768c248 into jenkins-infra:main Apr 11, 2023
@dduportal dduportal deleted the chore/cleanup-aws-staging-images branch April 11, 2023 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant