Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: preselect and prefill helpdesk account issue #196

Merged
merged 7 commits into from
Nov 24, 2022
Merged

feat: preselect and prefill helpdesk account issue #196

merged 7 commits into from
Nov 24, 2022

Conversation

lemeurherve
Copy link
Member

@lemeurherve lemeurherve commented Nov 18, 2022 •
edited
Loading

@lemeurherve lemeurherve changed the title feat: preselect and prefill account helpdesk issue feat: preselect and prefill helpdesk account issue Nov 18, 2022
@lemeurherve lemeurherve marked this pull request as draft November 18, 2022 18:09
@NotMyFault
Copy link
Member

Maybe we can do the same for the password reset assistance URL too?

account-app/src/main/resources/org/jenkinsci/account/Application/passwordReset.jelly

Line 18 in 3f7bdd4

If you can't figure this out, <a href="https://github.com/jenkins-infra/helpdesk/issues/new/choose">contact us</a> to get your account recovered.

@lemeurherve lemeurherve marked this pull request as ready for review November 23, 2022 09:22
@lemeurherve
Copy link
Member Author

Cf #197, tests are failing here, but a build with them and #198 combined is successful.

@lemeurherve lemeurherve mentioned this pull request Nov 23, 2022
Closed
@lemeurherve lemeurherve merged commit d2de8e4 into main Nov 24, 2022
@lemeurherve lemeurherve deleted the lemeurherve-patch-2 branch November 24, 2022 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timja timja timja approved these changes

@NotMyFault NotMyFault Awaiting requested review from NotMyFault

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lemeurherve @NotMyFault @timja @lemeurherveCB