-
Notifications
You must be signed in to change notification settings - Fork 524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wrap React.PropsWithChildren #598
base: master
Are you sure you want to change the base?
Conversation
DefinitelyTyped/DefinitelyTyped@55dc209 children is removed on React 18
Can this be merged please? |
I need it too u.u |
@jemise111 Would you review/merge/release this for us? |
I was also expecting this PR to be merged. You can fix it on your own using |
Thank you, I will try it while await for merge |
I also need this fix |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not a maintainer or anything on this project, but I don't think this PR could be merged in its current state.
I've offered some suggestions to tidy up the import you added.
import React = require('react'); | ||
import { Component } from 'react'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
import React = require('react'); | |
import { Component } from 'react'; | |
import { Component, PropsWithChildren } from 'react'; |
@@ -207,7 +208,7 @@ interface IPropsSwipeRow<T> { | |||
useNativeDriver: boolean; | |||
} | |||
|
|||
export class SwipeRow<T> extends Component<Partial<IPropsSwipeRow<T>>> { | |||
export class SwipeRow<T> extends Component<Partial<React.PropsWithChildren<IPropsSwipeRow<T>>>> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
export class SwipeRow<T> extends Component<Partial<React.PropsWithChildren<IPropsSwipeRow<T>>>> { | |
export class SwipeRow<T> extends Component<Partial<PropsWithChildren<IPropsSwipeRow<T>>>> { |
DefinitelyTyped/DefinitelyTyped@55dc209
children is removed on React 18
Thanks for submitting a pull request!
Please confirm you have linted your code and fixed any issues:
yarn run fix
on my PR and fixed any formatting issuesexecute result. None were relevant to this fix.
Please provide information on what your PR achieves and any issues that it addresses:
DefinitelyTyped/DefinitelyTyped@55dc209
children is removed on React 18. So I add.