Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use email.utils for parsing server time #918

Merged
merged 2 commits into from
Dec 21, 2024

Conversation

oddstr13
Copy link
Member

Fixes #916

@oddstr13 oddstr13 added bugfix needs-testing Some testing is requested/required before merging labels Sep 19, 2024
Copy link

codecov bot commented Sep 19, 2024

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.

Project coverage is 21.87%. Comparing base (6cc0bb6) to head (8d1ae2e).
Report is 82 commits behind head on master.

Files with missing lines Patch % Lines
jellyfin_kodi/library.py 0.00% 8 Missing ⚠️
jellyfin_kodi/jellyfin/http.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #918      +/-   ##
==========================================
- Coverage   21.90%   21.87%   -0.03%     
==========================================
  Files          63       63              
  Lines        8634     8686      +52     
  Branches     1587     1411     -176     
==========================================
+ Hits         1891     1900       +9     
- Misses       6722     6767      +45     
+ Partials       21       19       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@oddstr13 oddstr13 force-pushed the pr-iso-server-time-1 branch from 3427ab6 to 3c394bc Compare September 20, 2024 22:22
Copy link

@oddstr13
Copy link
Member Author

Related PR in KodiSyncQueue: jellyfin/jellyfin-plugin-kodisyncqueue#95

@oddstr13 oddstr13 marked this pull request as ready for review September 20, 2024 22:32
Copy link

@oddstr13 oddstr13 changed the title Use the new Server-Time header from KodiSyncQueue Use email.utils for parsing server time Dec 21, 2024
@oddstr13 oddstr13 removed the needs-testing Some testing is requested/required before merging label Dec 21, 2024
@oddstr13 oddstr13 requested a review from mcarlton00 December 21, 2024 02:23
@mcarlton00 mcarlton00 merged commit 44d5ee6 into jellyfin:master Dec 21, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

save_last_sync try to convert HTTP date header with a localized python date-time parser which is incorrect
2 participants