escape uri of path in get_file_path for http(s), ftp(s), dav(s)

[omelettedufromagee]

This change aims to import a working path into Kodi if the network shared path is using http, https, ftp, ftps, dav or davs protocol.
Currently, if a path contains a space, it is not replaced by %20 and becomes unreadable for Kodi.
requote_uri function ensures that the uri's special characters are properly encoded and passed safely.

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

[oddstr13]

Could you please provide tests for this? A list of expected inputs -> outputs, both what's now which is incorrect, and what's correct would do, I can implement the tests myself. :)

[omelettedufromagee]

Sure. Below some examples with https, it is also valid for protocols http, ftp, ftps, dav and davs.

Current behavior of path:
https://myserver.local/TV_Shows/My TV Show/My.TV.Show.S01E01.mkv
https://myserver.local/TV_Shows/Law&Github/Law&Github.S01E01.mkv

This results in Kodi trying to open and play "https://myserver.local/TV_Shows/My" or to use a literal ampersand in the URL which my break the call if you are using a webserver.

requote_uri passes the given URI through an unquote/quote cycle to ensure that it is fully and consistently quoted.

New behavior of path:
https://myserver.local/TV_Shows/My%20TV%20Show/My.TV.Show.S01E01.mkv
https://myserver.local/TV_Shows/Law%26Github/Law%26Github.S01E01.mkv

Moreover, I've been tested this for the past few months, I haven't got any issue. If anything, it strengthens the output to make sure a valid URL is generated for those protocols.
This resolves my issue of playing file through the Jellyfin websocket from Kodi, it is slower/buggier with big files. It works flawlessly when playing a file directly from the webdav or ftp server.

[omelettedufromagee]

Btw, #767 is similar so you should be able to close it aswell with this PR.

[oddstr13]

Btw, #767 is similar so you should be able to close it aswell with this PR.

Yes, I was planning to.

Could you test this with files that actually do contain escape sequences in the file names? Sounds like that might potentially cause issues.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

[codecov]

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 21.90%. Comparing base (6cc0bb6) to head (69f44d6).
Report is 14 commits behind head on master.

❗ Current head 69f44d6 differs from pull request most recent head d5fb95d

Please upload reports for the commit d5fb95d to get more accurate results.

Files with missing lines	Patch %	Lines
jellyfin_kodi/helper/api.py	33.33%	2 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##           master     #792   +/-   ##
=======================================
  Coverage   21.90%   21.90%           
=======================================
  Files          63       63           
  Lines        8634     8637    +3     
  Branches     1587     1588    +1     
=======================================
+ Hits         1891     1892    +1     
- Misses       6722     6724    +2     
  Partials       21       21           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud