Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix syncing of mixed TV libraries #774

Merged
merged 1 commit into from
Feb 8, 2024

Conversation

sonofsky2010
Copy link
Contributor

If the library was mixed, it can not be found since the it's ID has prefix "Mixed:".

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Sep 21, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (a112613) 21.05% compared to head (5b45d52) 21.06%.
Report is 66 commits behind head on master.

Files Patch % Lines
jellyfin_kodi/helper/utils.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #774      +/-   ##
==========================================
+ Coverage   21.05%   21.06%   +0.01%     
==========================================
  Files          63       63              
  Lines        8544     8543       -1     
  Branches     1573     1573              
==========================================
+ Hits         1799     1800       +1     
+ Misses       6729     6727       -2     
  Partials       16       16              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@oddstr13
Copy link
Member

oddstr13 commented Oct 3, 2023

I'll eventually get around to testing these changes, but in the mean time I suggest you formulate a good reason to keep the mixed library feature if it is important for your workflow, and you can't do without jellyfin/jellyfin-meta#46

@oddstr13 oddstr13 changed the title Fix: Some TV library sync failed, if the TV library was mixed. Fix syncing of mixed TV libraries Feb 8, 2024
@oddstr13 oddstr13 merged commit 455b70b into jellyfin:master Feb 8, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants