Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .nvmrc #521

Merged

Conversation

Drew-Daniels
Copy link
Contributor

@Drew-Daniels Drew-Daniels commented Jul 27, 2024

Adds an .nvmrc file that can be used by node runtime managers like nvm and mise to automatically use a specified version of node.

Ensures that all developers are using the same major version of node, and would hopefully lessen friction to newer developers getting started with the project.

Fixes #520

Copy link

@thornbill thornbill modified the milestones: v1.7.0, v1.6.0 Aug 21, 2024
@thornbill thornbill added the build This PR or issue mainly concerns build tools label Aug 21, 2024
@thornbill thornbill merged commit 4e8d1d2 into jellyfin:master Aug 21, 2024
7 checks passed
Copy link

codecov bot commented Aug 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.21%. Comparing base (9ace221) to head (bbdf64b).
Report is 29 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #521   +/-   ##
=======================================
  Coverage   60.21%   60.21%           
=======================================
  Files          46       46           
  Lines         945      945           
  Branches      189      187    -2     
=======================================
  Hits          569      569           
  Misses        341      341           
  Partials       35       35           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build This PR or issue mainly concerns build tools
Development

Successfully merging this pull request may close these issues.

NPM Install Never Finishes on Node v22
2 participants